Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twins prototype requirements #55

Closed
patrickkaleta opened this issue Mar 11, 2019 · 26 comments
Closed

Twins prototype requirements #55

patrickkaleta opened this issue Mar 11, 2019 · 26 comments
Assignees
Labels
BB: Scenario Transferability Scenario Transferability Building Block enhancement New feature or request STALLED important but currently not beeing worked on

Comments

@patrickkaleta
Copy link
Contributor

Last week, I started implementing a first prototype for the Twins in my local environtment using the Geofield_map and Geofield module.

So far, I have a new content type called "Twin" with the following fields:

  • Title
  • Summary
  • Link to an external website
  • Type of twin (Hazard twin, ....idk what other types there might be in the future but for now I think it’s just hazards)
  • Involved hazards
  • Involved elements at risk
  • Geolocation (stores just the point as latitude and longitude)

@Itsman-AT Do we need anything else for now?

On the Twins-tab in the study this could then look something like this:
prototype-for-twins

@Itsman-AT as discussed last week, we need a Google Maps API key, so that we can fully use the Geofield_map module. Let me know, once you have one.

@Itsman-AT
Copy link

@patrickkaleta : Thanky, looks good. I think we do not need more at the moment.

@patrickkaleta
Copy link
Contributor Author

@patrickkaleta : Thanky, looks good. I think we do not need more at the moment.

ok, I will implement this in the CSIS

@patrickkaleta
Copy link
Contributor Author

I implemented the entity type and the view and configured the GL-step and its view to display the twins.

For now, I also deactivated the Twins-tabs for all other steps except the first step (Hazard Characterization), since they are not yet defined and not even the mock-ups exist for those twins.

@Itsman-AT
Copy link

@Itsman-AT as discussed last week, we need a Google Maps API key, so that we can fully use the Geofield_map module. Let me know, once you have one.

@patrickkaleta : I sent you the Key via e-mail, please check, if it is working.

@patrickkaleta
Copy link
Contributor Author

@Itsman-AT: the key works. I've added it to the CSIS site.

@p-a-s-c-a-l p-a-s-c-a-l added enhancement New feature or request BB: Scenario Transferability Scenario Transferability Building Block labels Mar 12, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to To do in T4.4 Scenario Transferability via automation Mar 12, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.3 CLARITY CSIS v1 milestone Mar 12, 2019
@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Apr 16, 2019

Here is the updated Twins data model (already implemented in CSIS Drupal): Marketplace-Entities.svg

@Itsman-AT Please discuss the Hazard Twins with @DenoBeno. I seems that the Hazard Twins idea has been abandoned.

@patrickkaleta
Copy link
Contributor Author

@Itsman-AT Please discuss the Hazard Twins with @DenoBeno. I seems that the Hazard Twins idea has been abandoned.

I would appreciate a fast decision on this matter, since I'm currently working on a function to include these Twins (or whatever it's going to be in the end) into the final report (similar to the recently implemented Report image functionality)

Locally, I already managed to establish a working prototype, which displays the available Twins below the Twins-Map and separates them into those who are already included (always shown on top) and the ones who are available (and could be included in the report).
Knowing whether this has to work only for Twins or Showcases or for both will save me quite some time implementing this.
included-nonincluded twins

@p-a-s-c-a-l p-a-s-c-a-l added the STALLED important but currently not beeing worked on label Apr 30, 2019
@p-a-s-c-a-l
Copy link
Member

Some improvements that should be implemented before ECCA 2019:

Filter is applied on map only

The (Hazard) and type filter are applied on the map only, but not on the table

grafik

Twin Maps for additional EU-GL Steps

We should add Twin Maps for the other EU-GL Steps and show Twin and Showcase Entities that are assigned to the respective step.

For Twin and Showcase Entities related to Elements at Risk (EE Step) and [Adaptation Options] (IAO Step)), we can show Elements at Risk and Adaptation Options filters, too.

Avoid i18n duplicates

See clarity-h2020/marketplace#1 (comment)

@patrickkaleta
Copy link
Contributor Author

Some improvements that should be implemented before ECCA 2019:

Filter is applied on map only

The (Hazard) and type filter are applied on the map only, but not on the table

Filters are applied to the map and the table showing "Available Twins/Showcases". For the "Included in Study report" table I deactivated the filters on purpose, since IMO users would get confused if those filters would "remove" already selected Elements from their study again. But it's not a problem to change that and make the filters affect this table as well.

Twin Maps for additional EU-GL Steps

We should add Twin Maps for the other EU-GL Steps and show Twin and Showcase Entities that are assigned to the respective step.

For Twin and Showcase Entities related to Elements at Risk (EE Step) and [Adaptation Options] (IAO Step)), we can show Elements at Risk and Adaptation Options filters, too.

That's the way it was intended. I've hidden the Twins-Tab on all others steps, because currently all existing Twins/Showcases are assigned to the "Characterize Hazard" Step, so the Twins-Tab would be completely empty on all other steps. I'll have a look at it tomorrow to see if some of the Twins/Showcases would better fit into another step.

Regarding the shown select filters I talked to Denis and he wants (for now) to only show the "select hazard" option to keep it simple and not confuse the users. I therefore deactivated the "Select Type" option.

Avoid i18n duplicates

See clarity-h2020/marketplace#1 (comment)

Done, as mentioned in this comment.

@p-a-s-c-a-l
Copy link
Member

Filters are applied to the map and the table showing "Available Twins/Showcases".

You are right, it seems to work - but not very reliably. If you filter by "heat" and then by "flood" both tables disappear:

twins

For the "Included in Study report" table I deactivated the filters on purpose, since IMO users would get confused if those filters would "remove" already selected Elements from their study again.

You're right, the filter should be applied to the second table only.

@patrickkaleta
Copy link
Contributor Author

Filters are applied to the map and the table showing "Available Twins/Showcases".

You are right, it seems to work - but not very reliably. If you filter by "heat" and then by "flood" both tables disappear:

Strange, the tables disappear after the second time filter are applied (no matter which filters are used). Those filters are not custom-made but the ones provided by default by the Drupal Views. So probably it's just some misconfiguration, I'll check that.

@patrickkaleta
Copy link
Contributor Author

Grouping Twins/Showcases into the EU-GL Steps

I had a look at the currently available Twins/Showcases (10+1) and grouped them by the most relevant EU-GL step. For the Studis we now have Twins-Maps shown for the following 4 EU-GL Steps:

Hazard characterization:

  • 2003 European heat wave
  • 2013 Sardinia floods
  • Avalanche - Erdlach/Rax
  • Campania Region Landslides
  • !!! Heat Wave Index and Hazards in Vienna
  • !!! Severe Wind Chorvatsky Grob

Hazard characterization - Local effects:

  • Heavy rain hazard map for Wuppertal

Exposure Evaluation:

  • European Drought Observatory
  • Fire Danger in Europe

Adapt. Opt. Identification:

  • Airlite C02 absorbing paint ("adaptation option at work" example)
  • Drought Management Planning Policy: From Europe to Spain

@Itsman-AT could you please have a look and decide if this is reasonable or if you would change some of them? Also I prefixed some of the Twins with "!!!" - those have little to no description, so it would be great if this could be fixed.
Last question: Any idea/plans on when we can expect some new Twins?

@patrickkaleta
Copy link
Contributor Author

Filters are applied to the map and the table showing "Available Twins/Showcases".

You are right, it seems to work - but not very reliably. If you filter by "heat" and then by "flood" both tables disappear:

This bug is fixed now and tables stay visible after applying filters multiple times. Apparently Drupal's Contextual filters can run into problems when using Exposed filters and AJAX. Changing the Contextual filter's parameters was the solution.

@p-a-s-c-a-l
Copy link
Member

@patrickkaleta Now it seems that showcases are missing on map and in table.

@patrickkaleta
Copy link
Contributor Author

@p-a-s-c-a-l after having a look at all twins/showcases I moved some of them into different tabs (by setting the workflow_step field). So I moved the Heavy Rain in Wuppertal into the Hazards local effects tab (sorry if I didn't make it clear enough before). But if you think it should rather stay in the Hazards tab, I can move it back.

The second showcase cids GUP-MV is shown on the Exposure tab in the map and in the table (at least for me thats the case).

T4.4 Scenario Transferability automation moved this from To do to Done Jun 17, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to Backlog: High Priority in T1.3 Climate Services Co-creation via automation Oct 28, 2019
@p-a-s-c-a-l p-a-s-c-a-l moved this from Backlog: High Priority to Done in T1.3 Climate Services Co-creation Oct 30, 2019
@p-a-s-c-a-l
Copy link
Member

The Google Maps Platform server rejected your request. This IP, site or mobile application is not authorized to use this API key. Request received from IP address xxxxxxxxx, with referer: https://maps.googleapis.com/maps/api/staticmap?size=650x400&scale=1&zoom=5&language=en&maptype=roadmap&markers=color:0xFF0000|size:normal|59.333759%2C18.074999&sensor=false&key=XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

at https://csis.myclimateservice.eu/node/1287

@Itsman-AT Can you please check what's going on? Quota exceeded, wrong key?

@p-a-s-c-a-l p-a-s-c-a-l reopened this Jan 14, 2020
T1.3 Climate Services Co-creation automation moved this from Done to In Progress Jan 14, 2020
T4.4 Scenario Transferability automation moved this from Done to In progress Jan 14, 2020
@Itsman-AT
Copy link

@Itsman-AT Can you please check what's going on? Quota exceeded, wrong key?
I will check it now.

@Itsman-AT
Copy link

First find: Quota does not seem to be exceeded:

Free trial status: €251.05 credit and 57 days remaining - with a full account, you'll get unlimited access to all of Google Cloud Platform.

@Itsman-AT
Copy link

Hm, for me the above link works with the Google Maps API key:

grafik

@Itsman-AT
Copy link

Although there seem to have been errors in the past:

grafik

and I do not know what this graph means:

grafik

@Itsman-AT
Copy link

I am investigating on the 100% error value.

@p-a-s-c-a-l
Copy link
Member

Works in _Chrome. Probably a firefox issue. They added a lot of tracking protection functionality lately.

57 days remaining

O.K. And what happens on day 58? :-)

@Itsman-AT
Copy link

O.K. And what happens on day 58? :-)

AIT DRC would have to pay the bill :-) - not a good solution ;-)

@p-a-s-c-a-l
Copy link
Member

IMHO this is revolved and can be closed?

@Itsman-AT
Copy link

IMHO this is revolved and can be closed?

@p-a-s-c-a-l : Yes, please close the issue. We will handle this AIT internally.

T1.3 Climate Services Co-creation automation moved this from In Progress to Done Feb 20, 2020
T4.4 Scenario Transferability automation moved this from In progress to Done Feb 20, 2020
@Itsman-AT
Copy link

@DenoBeno : Did you already create a DSS Google Maps Billing Account for Clarity? The Key expired now which is unfortunate. Can I be of any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Scenario Transferability Scenario Transferability Building Block enhancement New feature or request STALLED important but currently not beeing worked on
Projects
No open projects
Development

No branches or pull requests

4 participants