Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcases on Twins Map #8

Closed
p-a-s-c-a-l opened this issue Apr 17, 2019 · 4 comments
Closed

Showcases on Twins Map #8

p-a-s-c-a-l opened this issue Apr 17, 2019 · 4 comments
Assignees
Labels
BB: Marketplace myclimateservice.eu Marketplace BB: Scenario Transferability Scenario Transferability Building Block enhancement New feature or request
Milestone

Comments

@p-a-s-c-a-l
Copy link
Member

Showcases should be shown on the Twins Map.

@p-a-s-c-a-l p-a-s-c-a-l added enhancement New feature or request BB: Marketplace myclimateservice.eu Marketplace BB: Scenario Transferability Scenario Transferability Building Block labels Apr 17, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the ECCA 2019 milestone Apr 17, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to To Do in T5.4 Climate Service Marketplace via automation Apr 17, 2019
@patrickkaleta
Copy link

Showcases are now shown together with Twins on the Twins map, as well as in the table below that map. Next step for me is now to implement the mechanism to include/remove Showcases (and or Twins) to the Study report.

@patrickkaleta
Copy link

Another question now is how we want to distinguish between Showcases and Twins (and possibly even Twin types?). For displaying different icons on the map, the Geofield map module provides two general options:

  • distinguish by content type: so we would get different icons for Showcases and Twins -> no need to change current data model
  • or distinguish by a field (cardinality of this field has to be 1:1, so the current fields Hazards and El. at risk won't work!):
    • we could add a dedicated field called "icon" to both content types, so the author can set the icon directly
    • or we use the field (Twin) type to set different icons (since Showcases don't have this property yet, they would all get assigend to one default icon)

Idk if Showcases will ever have something like the type field in Twins. But if so, I would suggest "turning" this type field into a dedicated taxonomy (currently it's just a list of strings) and use it in Showcases and Twins. The overall complexity of the data structure gets increased a little, but we would gain a lot more flexibility, since it's easier to manage/update a taxnomy than a simple list of strings.

@p-a-s-c-a-l
Copy link
Member Author

distinguish by content type: so we would get different icons for Showcases and Twins -> no need to change current data model

Following KISS and YAGNI, I would first go for this option and consider the other options later, if needed.

we could add a dedicated field called "icon" to both content types, so the author can set the icon directly

Then we would have to offer a list of icons the user an choose from. (probably implemented as taxonomy :-)

or we use the field (Twin) type to set different icons
I would suggest "turning" this type field into a dedicated taxonomy (currently it's just a list of strings) and use it in Showcases and Twins

Twins and Solution Offers do not share common types taxonomy, so this taxonomy would be semantically incoherent. Furthermore, there is no type field in the Showcase entity but in the in the Solution Offer entity. I would keep it as it is and wait for end user feedback before making further changes.

@p-a-s-c-a-l p-a-s-c-a-l moved this from To Do to In progress in T5.4 Climate Service Marketplace Apr 30, 2019
@p-a-s-c-a-l p-a-s-c-a-l self-assigned this May 14, 2019
@p-a-s-c-a-l
Copy link
Member Author

As we cannot wait for the outcome of this discussion I added a hidden field twins_type to the showcases entity which defaults to 'Showcase' just for the sake of showing different map icons:

grafik

T5.4 Climate Service Marketplace automation moved this from In progress to Done May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Marketplace myclimateservice.eu Marketplace BB: Scenario Transferability Scenario Transferability Building Block enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

4 participants