Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

69 deprecation warnings need dealing with #71

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

jonbarker68
Copy link
Contributor

Fixing deprecation warnings that have been exposed by the test suite.

jonbarker68 and others added 5 commits August 14, 2022 19:10
- np.int and np.float replaced with int and float
- np.linalg.lstsq needs the rcond=-1 argument
Librosa issues warning every time it reads an mp3 file. Disabling
the warning as we use a lot of mp3 files and it is just confusing.
…pendingdeprecationwarning

Fixed NumbaPendingDeprecationWarnings
@jonbarker68 jonbarker68 linked an issue Aug 14, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #71 (2b84d79) into main (df3105c) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   82.87%   82.90%   +0.03%     
==========================================
  Files          30       30              
  Lines        3358     3364       +6     
==========================================
+ Hits         2783     2789       +6     
  Misses        575      575              
Impacted Files Coverage Δ
clarity/enhancer/gha/gainrule_camfit.py 92.46% <ø> (ø)
clarity/predictor/torch_msbg.py 80.27% <70.00%> (ø)
clarity/data/HOA_tools_cec2.py 96.85% <100.00%> (+0.06%) ⬆️
clarity/data/scene_renderer_cec2.py 91.61% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonbarker68
Copy link
Contributor Author

@ns-rse this PR is just dealing with some minor deprecation warnings that were caught by the test suite. Nothing very important but some of them would have led to problems later. We might as well merge this into main before releasing v0.1.0

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that its good to get these resolved earlier. All very minor changes as you wrote.

@ns-rse ns-rse merged commit 0c40b4e into main Aug 15, 2022
@ns-rse ns-rse deleted the 69-deprecation-warnings-need-dealing-with branch August 15, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings need dealing with
3 participants