New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't convert values to strings before storing #35

Closed

shai32 opened this issue Sep 22, 2017 · 1 comment · Fixed by #37

shai32 commented Sep 22, 2017

localstorage does not support setting objects. (it save them as "[object Object]")
so the mock should act the same

Owner

clarkbw commented Sep 26, 2017

Oh right, I think it runs a toString method on value being passed.

clarkbw changed the title ~~not acts like a real localstorage~~ Doesn't convert values to strings before storing

clarkbw pushed a commit that referenced this issue


          Always coerce values to a string before saving

e12df80

This fixes #35

clarkbw mentioned this issue

Always coerce values to a string before saving #37

Merged

clarkbw closed this as completed in #37

clarkbw mentioned this issue

The undefined value is inconsistent with the browser #142

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment