Skip to content

Commit

Permalink
Merge pull request #9 from clarkduvall/fix-spelling
Browse files Browse the repository at this point in the history
Fix spelling of overridden
  • Loading branch information
clarkduvall committed Sep 11, 2015
2 parents 3663aaf + 87d6e4f commit 935f98d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions serpy/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ def to_value(self, value):
return value
to_value._serpy_base_implementation = True

def _is_to_value_overriden(self):
def _is_to_value_overridden(self):
to_value = self.to_value
# If to_value isn't a method, it must have been overriden.
# If to_value isn't a method, it must have been overridden.
if not isinstance(to_value, types.MethodType):
return True
return not getattr(to_value, '_serpy_base_implementation', False)
Expand Down
4 changes: 2 additions & 2 deletions serpy/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ def _compile_field_to_tuple(field, name, serializer_cls):
if getter is None:
getter = serializer_cls.default_getter(field.attr or name)

# Only set a to_value function if it has been overriden for performance.
# Only set a to_value function if it has been overridden for performance.
to_value = None
if field._is_to_value_overriden():
if field._is_to_value_overridden():
to_value = field.to_value

return (name, getter, to_value, field.call, field.required,
Expand Down
8 changes: 4 additions & 4 deletions tests/test_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ def test_to_value_noop(self):
def test_as_getter_none(self):
self.assertEqual(Field().as_getter(None, None), None)

def test_is_to_value_overriden(self):
def test_is_to_value_overridden(self):
class TransField(Field):
def to_value(self, value):
return value

field = Field()
self.assertFalse(field._is_to_value_overriden())
self.assertFalse(field._is_to_value_overridden())
field = TransField()
self.assertTrue(field._is_to_value_overriden())
self.assertTrue(field._is_to_value_overridden())
field = IntField()
self.assertTrue(field._is_to_value_overriden())
self.assertTrue(field._is_to_value_overridden())

def test_str_field(self):
field = StrField()
Expand Down

0 comments on commit 935f98d

Please sign in to comment.