Add Custom Overlay Color Editor #34
Conversation
There was a problem hiding this comment.
Works on my machine!
I also know our end goal doesn't plan on using the pug templating so if that's the plan just to get some features on the board I approve.
Now that we are at this milestone if we can talk about what are the next few major goals you want to accomplish is to hit twitchcon.
src/files.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { appendFile, existsSync, writeFile } from 'fs'; | |||
There was a problem hiding this comment.
The name of this file can be more descriptive. I don't know the future of the file, but its explicitly writing to a custom styles class
src/files.ts
Outdated
| }); | ||
| }); | ||
| } | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
The complexity is high with this one, probably going to refactor moving forward, but pull request to me makes it seems like this code is going into master.
src/routes/save-css.ts
Outdated
| import * as files from '../files'; | ||
|
|
||
| export const saveCssRoute = (req: express.Request, res: express.Response) => { | ||
| const captains = console; |
There was a problem hiding this comment.
This can use the log class
src/routes/save-css.ts
Outdated
| const data = formatForCSS(colorName, hueRotateDeg); | ||
| files | ||
| .write(data) | ||
| .then((result: any) => { |
There was a problem hiding this comment.
You should be able to type what the result is going to be.
| $('#container').css('filter', `hue-rotate(${hueRotateDeg}deg)`); | ||
| } | ||
|
|
||
| function request(requestOptions) { |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information