Comments and Multi-line Highlight Support

[parithon]

Purpose

Allow users to highlight multiple lines.

Changed Files

• extension.ts Added the necessary functionality to handle a start and end line and to add the highlights and remove the highlights accordingly. Additionally, the user can now add comments to the highlight!
• highlighter.ts Added support for a start and end line
• twitchChatClient.ts Added support to pass the correct params to extension.ts
• twitchHighlighterTreeView.ts Changed the naming of the parameters to identify their purpose
• twitchLanguageServer.ts Added the functionally needed to handle the command. Take special notice of the Regex used for this purpose.

How to test

1. Clone the repo: git clone https://github.com/clarkio/vscode-twitch-highlighter.git.
2. Install the node dependencies: cd vscode-twitch-highlighter && npm install.
3. Press F5 or click debug button (green triangle/play button) in VSCode.
4. Connect to the chat server.
5. Use the highlight command !line or !highlight to highlight multiple lines and to add comments.
6. Use the unhighlight command !line !<number> to unhighlight the lines.

Addresses

#52 | #12 | #13

[clarkio]

Haven't had a chance to run the code yet to test it but does this also support !line 5 settings.json? I only ask because it feels like that may be the natural/organic way to type/think about the usage. Do you agree? Might just be me who thinks that way though.

In general, how would we think/speak what we want to share? Something like "There's an issue on line 5 in your settings.json file"? Or "There's an issue in your settings.json file on line 5"? Should we support both or just one?

[parithon]

Right now it would not support !line 5 settings.json but I can adjust the regex pattern to support that flow. See https://regexr.com/48gf0 to test the pattern.

[parithon]

Just pushed a new commit which supports @clarkio's suggestion

[clarkio]

Looks good to me! Thanks!