Improve consistency of time-based testing

clarkmalmgren · Aug 14, 2017 · c0c26d2 · c0c26d2
1 parent 89bef01
commit c0c26d2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/src/app/components/pages/sermons/sermon.spec.ts b/src/app/components/pages/sermons/sermon.spec.ts
@@ -1,6 +1,6 @@
-import { expect, sinon, async, MockBuilder }  from 'testing';
-import { ActivatedRoute }                     from '@angular/router';
-import { SermonComponent }                    from './sermon';
+import { expect, sinon, async, MockBuilder, callCount } from 'testing';
+import { ActivatedRoute }                               from '@angular/router';
+import { SermonComponent }                              from './sermon';
 import {
   Analytics,
   FeatureToggles,
@@ -49,15 +49,16 @@ describe('SermonComponent', () => {
                           .build();
 
       const sermon = new SermonComponent(activatedRoute, analytics, null, null, null, null, youtubeService);
-      sermon.analyticsInterval = 10;
+      sermon.analyticsInterval = 5;
       sermon.videoState = VideoState.PLAYING;
       sermon.sermon = { youtube: 'Jesus4Life' } as Sermon;
 
       sermon.ngOnInit();
 
       window.setTimeout(() => {
-        expect(analytics.event).to.have.been.calledTwice
-          .and.to.have.been.calledWith('Sermon', 'Playing', 'Jesus4Life');
+        /* Giving a reasonable range to account for annoying time based testing */
+        expect(callCount(analytics.event)).to.be.at.least(2).and.at.most(6);
+        expect(analytics.event).to.have.been.calledWith('Sermon', 'Playing', 'Jesus4Life');
         sermon.ngOnDestroy();
       }, 25);
     }));
@@ -76,7 +77,7 @@ describe('SermonComponent', () => {
                           .build();
 
       const sermon = new SermonComponent(activatedRoute, analytics, null, null, null, null, youtubeService);
-      sermon.analyticsInterval = 10;
+      sermon.analyticsInterval = 5;
       sermon.videoState = VideoState.PLAYING;
       sermon.live = true;
       sermon.sermon = { youtube: 'Jesus4Life' } as Sermon;
@@ -110,7 +111,7 @@ describe('SermonComponent', () => {
                             .build();
 
         const sermon = new SermonComponent(activatedRoute, analytics, null, null, null, null, youtubeService);
-        sermon.analyticsInterval = 10;
+        sermon.analyticsInterval = 5;
         sermon.videoState = state;
         sermon.sermon = { youtube: 'Jesus4Life' } as Sermon;
 

diff --git a/src/testing.ts b/src/testing.ts
@@ -42,6 +42,10 @@ export class MockBuilder<T> {
   }
 }
 
+export function callCount(spy: any) {
+  return spy.callCount;
+}
+
 export class Loop {
   static times(n: number) {
     return new Loop(n);