Add handling for Windows "readline.__doc__ is NoneType" error. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain Windows installs, readline.__doc__ is None. Check before trying to search within it.
|
Python 2.6 and 3.3 are both EOL--hence the failing builds. |
|
@clarkperkins, could this be merged? |
|
Hi @bafulton, sorry I have been slow to respond to this! I'll merge and get a new release pushed to pypi. |
|
@clarkperkins, no worries! Thanks for merging! |
fwkz
added a commit
to fwkz/riposte
that referenced
this pull request
Mar 4, 2024
## Changes In certain Windows installs, readline.__doc__ is None. Added a check before iterating. ## Issue Improving Windows compatibility #9 ## Related pull request Add compatibility for Windows #14 ## Inspiration [Add handling for Windows "readline.__doc__ is NoneType" error](clarkperkins/click-shell#11) --------- Co-authored-by: Mariusz Kupidura <2480867+fwkz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain Windows installs, readline.doc is None. Check before trying to search for the phrase "libedit" inside it.