Standardize sending message : #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Zowac
commented
Mar 5, 2021
Zowac
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Fixed issues | comma-separated list of issues fixed by the PR, if any |
Zowac
force-pushed
the
standardize-sending-messages
branch
9 times, most recently
from
9cb6f25
to
723614f
Compare
Zowac
force-pushed
the
standardize-sending-messages
branch
4 times, most recently
from
31707a2
to
b062c49
Compare
Zowac
changed the title
Zowac
force-pushed
the
standardize-sending-messages
branch
3 times, most recently
from
9cec3e7
to
a477ee6
Compare
Elorfin
requested changes
Mar 16, 2021
Zowac
force-pushed
the
standardize-sending-messages
branch
2 times, most recently
from
f29cffc
to
274d5c4
Compare
Elorfin
requested changes
Mar 16, 2021
src/plugin/planned-notification/Manager/PlannedNotificationManager.php
Outdated
Show resolved
Hide resolved
Zowac
force-pushed
the
standardize-sending-messages
branch
from
274d5c4
to
c6fa2d5
Compare
Zowac
force-pushed
the
standardize-sending-messages
branch
from
c6fa2d5
to
29d04c0
Compare
Elorfin
requested changes
Mar 17, 2021
Zowac
force-pushed
the
standardize-sending-messages
branch
from
29d04c0
to
956d0f9
Compare
- Dispatch event instead of using MailManager::send() - Refacto MessageListener to use only one method/event - Refacto SendMessageEvent => possibility to make properties null && changing the position of properties
- Create MessageEvents - Use Subscriber instead of listener - Use MessageEvents const
- Log event when message is send
Zowac
force-pushed
the
standardize-sending-messages
branch
from
956d0f9
to
fad7e28
Compare
Elorfin
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.