Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements Security logs : #1614

Merged
merged 6 commits into from
Mar 22, 2021
Merged

Improvements Security logs : #1614

merged 6 commits into from
Mar 22, 2021

Conversation

Zowac
Copy link
Contributor

@Zowac Zowac commented Mar 12, 2021 •
edited

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Fixed issues comma-separated list of issues fixed by the PR, if any

Try to search for the user when authentication fails
Add a tab to show user-specific security logs
Top-down datas retrieval to get the last entry first

@Zowac Zowac force-pushed the improvement-logs-security branch 3 times, most recently from 4eb1f80 to f55b203 Compare March 16, 2021 10:09
@Zowac Zowac force-pushed the improvement-logs-security branch 2 times, most recently from 96cf4d8 to 3088c81 Compare March 17, 2021 14:05
@Zowac
Feedback:
bdbd722 
- Search the User on authentication failure
@Zowac
Improvement - WIP:
71f06e4 
- Order log by DESC
@Zowac
Review:
09d28e4 
- Use ObjectManager instead of UserRepository
- Remove previously created function and use findByName instead
@Zowac
Improvement logs security - WIP:
7491399 
- Add a tab for the current user with his security logs
@Zowac Zowac force-pushed the improvement-logs-security branch 2 times, most recently from f388aa0 to dd49d87 Compare March 18, 2021 10:27
@Zowac
Improvement logs security:
2f2f2f5 
- add list of logs from current user
@Zowac Zowac force-pushed the improvement-logs-security branch from dd49d87 to 2f2f2f5 Compare March 18, 2021 11:04
@Zowac Zowac changed the title [WIP] Improvement: Improvement: Mar 18, 2021
@Zowac Zowac changed the title Improvement: Improvements Security logs : Mar 18, 2021
@Zowac Zowac requested a review from Elorfin March 18, 2021 11:06
@Zowac Zowac force-pushed the improvement-logs-security branch 2 times, most recently from 6e3d698 to 6eda2f2 Compare March 19, 2021 15:06
@Zowac
Review :
3f58508 
- Change function name
- Remove useless finder's property
- Initialize the default sort in UI
@Zowac Zowac force-pushed the improvement-logs-security branch from 6eda2f2 to 3f58508 Compare March 19, 2021 15:41
Elorfin
Elorfin reviewed Mar 22, 2021
View reviewed changes
src/main/core/Controller/APINew/Log/SecurityLogController.php
/**
* @Route("/list/current", name="apiv2_logs_security_list_current", methods={"GET"})
*/
public function userLogSecurtiyAction(Request $request): JsonResponse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo still here Securtiy :p

@Elorfin Elorfin merged commit 093c47a into claroline:13.x Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elorfin Elorfin Elorfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zowac @Elorfin