-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursus enhancement #2788
Cursus enhancement #2788
Conversation
WolfyWin
commented
May 2, 2024
•
edited
Loading
edited
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
599a9c0
to
9dbb932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne vois pas la création des Formations depuis l'outil Formation de l'espace d'activités.
(Tu devrais avoir une nouvelle route dans l'outil comme dans celui du Bureau).
src/plugin/cursus/Resources/modules/course/components/creation.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/tools/trainings/catalog/store/reducer.js
Outdated
Show resolved
Hide resolved
742816a
to
2a6fbff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La solution pour gérer les routes sans faire du cas par cas comme tu as fait est de normaliser les routes entre l'outil du bureau et celui de l'espace d'activité.
Il faut rajouter le slug
de la formation dans les routes de l'outil workspace :
/about/ma_formation
/about/ma_formation/edit
/catalog/ma_formation
/catalog/ma_formation/edit
Comme ça depuis ton outil tu passes soit props.toolPath+'/catalog'
ou props.toolPath+'/about'
(dans cet exemple props.toolPath
contient la valeur de toolSelectors.path
) à tes composants de création, édition et détail du module course
. Ensuite dans le module course, tu reconstruis tous les chemins à partir de l'utilitaire route()
.
src/plugin/cursus/Resources/modules/course/components/about.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/course/components/about.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/course/components/parameters.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/course/components/registration.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/course/components/sessions.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/session/components/list.jsx
Outdated
Show resolved
Hide resolved
src/plugin/cursus/Resources/modules/session/components/list.jsx
Outdated
Show resolved
Hide resolved
a95ac87
to
2916200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta fonction route était correct, il ne fallait pas la modifier. Le basePath en param doit contenir le résultat de toolSelectors.path
qui contient soit /workspace/${workspace.slug}/training_events
, soit /desktop/trainings
suivant l'endroit où tu es.