Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursus enhancement #2788

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Cursus enhancement #2788

merged 9 commits into from
Jun 10, 2024

Conversation

WolfyWin
Copy link
Contributor

@WolfyWin WolfyWin commented May 2, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no

@WolfyWin WolfyWin force-pushed the cursus branch 5 times, most recently from 599a9c0 to 9dbb932 Compare May 6, 2024 16:49
@WolfyWin WolfyWin requested a review from Elorfin May 7, 2024 13:44
Copy link
Member

@Elorfin Elorfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne vois pas la création des Formations depuis l'outil Formation de l'espace d'activités.
(Tu devrais avoir une nouvelle route dans l'outil comme dans celui du Bureau).

Copy link
Member

@Elorfin Elorfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La solution pour gérer les routes sans faire du cas par cas comme tu as fait est de normaliser les routes entre l'outil du bureau et celui de l'espace d'activité.

Il faut rajouter le slug de la formation dans les routes de l'outil workspace :

/about/ma_formation
/about/ma_formation/edit

/catalog/ma_formation
/catalog/ma_formation/edit

Comme ça depuis ton outil tu passes soit props.toolPath+'/catalog' ou props.toolPath+'/about' (dans cet exemple props.toolPath contient la valeur de toolSelectors.path) à tes composants de création, édition et détail du module course. Ensuite dans le module course, tu reconstruis tous les chemins à partir de l'utilitaire route().

@WolfyWin WolfyWin force-pushed the cursus branch 2 times, most recently from a95ac87 to 2916200 Compare June 3, 2024 12:57
@WolfyWin WolfyWin requested review from Elorfin and removed request for Elorfin June 3, 2024 13:22
Copy link
Member

@Elorfin Elorfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta fonction route était correct, il ne fallait pas la modifier. Le basePath en param doit contenir le résultat de toolSelectors.path qui contient soit /workspace/${workspace.slug}/training_events , soit /desktop/trainings suivant l'endroit où tu es.

https://github.com/claroline/Claroline/pull/2788/files#diff-a351e82ac142fb7899899a58ca3640fc34ade17e1a77956792794f24f61da7cfR3

@Elorfin Elorfin merged commit e4b2565 into 14.2 Jun 10, 2024
2 checks passed
@Elorfin Elorfin deleted the cursus branch June 10, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants