Behaves differently: zipWith3 f a b c / f <$> a <*> b <*> c
#2723
Labels
Comments
|
No specialisation takes place, so it cannot be a specialisation cache issue. The "problem" is where it inlines the definition of clash-compiler/clash-ghc/src-ghc/Clash/GHC/Evaluator/Primitive.hs Lines 192 to 216 in a245bb8 zipWith.
|
martijnbastiaan
changed the title
zipWith3 f a b c / f <$> a <*> b <*> czipWith3 f a b c / f <$> a <*> b <*> c
|
Why do we have a blackbox for In this specific case the behavior of the bb is better btw, though correctness obviously beats prettiness. |
|
Haskell-to-HDL compile speed. Without them, the clash compiler would have to unfold/unroll all functions over vector. That could increase compile times by 100x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
That is, the following causes Clash to generate one module for
bbWrapper:But the following generates tries to generate 4:
Reproducer (note that this reproducer will fail to error if #2722 gets fixed):
{-# LANGUAGE CPP #-} {-# LANGUAGE OverloadedStrings #-} -- | Test @zipWith3 f a b c@ behaves the same as @f <$> a <*> b <*> c@ when it -- comes to specialization caches. module T2723 where import Clash.Explicit.Prelude import Clash.Annotations.Primitive (Primitive(..)) import Clash.Backend (blockDecl) import Data.Monoid (Ap(getAp)) import qualified Clash.Netlist.Types as N import qualified Clash.Netlist.Id as Id bbTF :: N.TemplateFunction bbTF = N.TemplateFunction used valid $ \_bbCtx -> do x <- Id.make "x" () <- case Id.toText x of "x" -> pure () xName -> error $ "Unexpected name: " <> show xName <> ". Expected: x." getAp $ blockDecl x [N.NetDecl Nothing x N.Bit] where used = [0,1] valid _ = True {-# ANN bb (InlinePrimitive [minBound..] "[ { \"BlackBox\" : { \"name\" : \"T2723.bb\", \"kind\": \"Declaration\", \"workInfo\": \"Always\", \"format\": \"Haskell\", \"templateFunction\": \"T2723.bbTF\"}} ]") #-} bb :: Signal System Bit bb = pure low {-# CLASH_OPAQUE bb #-} bbWrapper :: Index n -> Index n -> Index n -> Signal System Bit bbWrapper !_ !_ !_ = bb {-# CLASH_OPAQUE bbWrapper #-} -- FAILS: topEntity :: Vec 4 (Signal System Bit) topEntity = bbWrapper <$> indicesI <*> indicesI <*> indicesI {-# CLASH_OPAQUE topEntity #-} -- OK: -- topEntity :: Vec 4 (Signal System Bit) -- topEntity v = zipWith3 bbWrapper v indicesI indicesI -- {-# CLASH_OPAQUE topEntity #-}Gives:
I'm somewhat undecided whether this is a
bugor anenhancement, so I've labelled them as both.The text was updated successfully, but these errors were encountered: