-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ClanWar): add getMemberByMapPosition #189
base: main
Are you sure you want to change the base?
feat(ClanWar): add getMemberByMapPosition #189
Conversation
Add method to ClanWar to provide encapsulated functionality for getting a member by their map position in war.
can you please bump the version as well? |
Done! |
I would like to bring to your attention a slight inaccuracy in the mapPosition for CWL. When the team size is 30, but all 50 members were registered during the signup process, the mapPosition value exceeds 30. |
The mapPosition is based on the registered member list for CWL If you do |
How do you recommend I work around that? If it can return the wrong member then there is no way (that I can think of) to work around that. I could remove the functionality for CWL by checking the ClanWar type and return null if it is equal to CWL. What do you think? |
If you sort them by the mapPosition, the |
However, I'm not sure if the members are already sorted by the mapPosition. |
Did you confirm? |
It is not sorted. |
Add method to ClanWar to provide encapsulated functionality for getting a member by their map position in war.