Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace keyv with custom store #99

Merged
merged 7 commits into from
Jan 29, 2022
Merged

refactor: replace keyv with custom store #99

merged 7 commits into from
Jan 29, 2022

Conversation

csuvajit
Copy link
Contributor

@csuvajit csuvajit commented Jan 28, 2022 •
edited

Keyv does not seem to be deleting the expired cache until Keyv#get is called for a specific key.

@csuvajit csuvajit marked this pull request as ready for review January 28, 2022 15:29
bsantosh909
bsantosh909 approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@bsantosh909 bsantosh909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuvajit csuvajit changed the title refactor: replace keyv with Map refactor: replace Keyv with Custom Store Jan 29, 2022
@csuvajit csuvajit changed the title refactor: replace Keyv with Custom Store refactor: replace keyv with custom store Jan 29, 2022
@csuvajit csuvajit merged commit 12b59ce into clashperk:master Jan 29, 2022
@csuvajit csuvajit deleted the next branch January 29, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsantosh909 bsantosh909 bsantosh909 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csuvajit @bsantosh909