Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ed hooks #1170

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Add ed hooks #1170

merged 2 commits into from
Jun 1, 2021

Conversation

yitzchak
Copy link
Member

Makes cl:ed actually do something. Idea copied from SBCL.

@yitzchak
Copy link
Member Author

Please note that ccl and allegro also have something similar. Ecl appears use the environment variable EDITOR and cmucl uses hemlock.

@Bike
Copy link
Member

Bike commented Jun 1, 2021

I'll do a little bit of cleanup and then merge this. Out of curiosity, do you actually use the ed function?

@yitzchak
Copy link
Member Author

yitzchak commented Jun 1, 2021

I am exploring using it in Jupyter. There is a message that you can pass from the kernel to the frontend UI that will open a file in an editor. It doesn't work in Jupyter Lab, but it does work in the Qt console. Just playing around right now, though.

@yitzchak
Copy link
Member Author

yitzchak commented Jun 1, 2021

Here is a video of it being used in SBCL if you are curious. https://1drv.ms/u/s!Aov9gbLSddWe0HZCBUovvBIRFASF?e=3gMpsK

@Bike Bike merged commit ac276d2 into clasp-developers:main Jun 1, 2021
@yitzchak yitzchak deleted the add-ed-hooks branch June 1, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants