Skip to content

Commit

Permalink
Merge pull request #869 from dominik2611/issues/843_jboss-vfs-adjustm…
Browse files Browse the repository at this point in the history 
…ents

Issues/843 jboss vfs adjustments
  • Loading branch information
@lukehutch
lukehutch committed Jun 18, 2024
2 parents 9b62ebc + c419fd5 commit 053ed8d
Showing 1 changed file with 132 additions and 21 deletions.
153 changes: 132 additions & 21 deletions src/main/java/nonapi/io/github/classgraph/classloaderhandler/JBossClassLoaderHandler.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,15 @@

import java.io.File;
import java.lang.reflect.Array;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;

import nonapi.io.github.classgraph.classpath.ClassLoaderOrder;
import nonapi.io.github.classgraph.classpath.ClasspathOrder;
import nonapi.io.github.classgraph.scanspec.ScanSpec;
Expand Down Expand Up @@ -79,7 +80,7 @@ public static boolean canHandle(final Class<?> classLoaderClass, final LogNode l
* the log
*/
public static void findClassLoaderOrder(final ClassLoader classLoader, final ClassLoaderOrder classLoaderOrder,
final LogNode log) {
final LogNode log) {
classLoaderOrder.delegateTo(classLoader.getParent(), /* isParent = */ true, log);
classLoaderOrder.add(classLoader, log);
}
Expand All @@ -99,16 +100,138 @@ public static void findClassLoaderOrder(final ClassLoader classLoader, final Cla
* the log
*/
private static void handleResourceLoader(final Object resourceLoader, final ClassLoader classLoader,
final ClasspathOrder classpathOrderOut, final ScanSpec scanSpec, final LogNode log) {
final ClasspathOrder classpathOrderOut, final ScanSpec scanSpec, final LogNode log) {
if (resourceLoader == null) {
return;
}
// PathResourceLoader has root field, which is a Path object
final Object root = classpathOrderOut.reflectionUtils.getFieldVal(false, resourceLoader, "root");

String path = loadJarPathFromClassicVFS(root, classpathOrderOut);
if(!isPathExisting(path)) {
path = loadJarPathFromNewVFS(root, classpathOrderOut);
}

if (path == null) {
final File file = (File) classpathOrderOut.reflectionUtils.getFieldVal(false, resourceLoader,
"fileOfJar");
if (file != null) {
path = file.getAbsolutePath();
}
}
if (path != null) {
classpathOrderOut.addClasspathEntry(path, classLoader, scanSpec, log);
} else {
if (log != null) {
log.log("Could not determine classpath for ResourceLoader: " + resourceLoader);
}
}
}

/**
* Checks if the given path exists and is a regular file.
*
* @param path the path to check
* @return true if the path exists and is a regular file, false otherwise
*/
private static boolean isPathExisting(String path) {
if(path != null && !path.isEmpty()) {
Path possibleExistingPath = Paths.get(path);
return Files.exists(possibleExistingPath) && Files.isRegularFile(possibleExistingPath);
}
return false;
}

/**
* Returns the absolute path of a JAR file from a given root object using the JBoss VFS mechanism.
* This works for Versions of JBoss/Wildfly that contain the following change:
* <a href="https://issues.redhat.com/browse/WFLY-18544">WFLY-18544</a>
* <a href="https://issues.redhat.com/browse/JBEAP-25879">JBEAP-25879</a>
* <a href="https://issues.redhat.com/browse/JBEAP-25677">JBEAP-25677</a>
* @param root The root object to get the JAR path from.
* @param classpathOrderOut The ClasspathOrder object for updating the classpath order.
* @return The absolute path of the JAR file, or null if the path couldn't be found.
*/
private static String loadJarPathFromNewVFS(final Object root, final ClasspathOrder classpathOrderOut) {

if (root == null) return null;

Class<?> jbossVFS = getJBossVFSAccess(root);
if(jbossVFS == null) return null;

// try to find the mount of the root. Type is org.jboss.vfs.VFS.Mount
Object mount = classpathOrderOut.reflectionUtils.invokeStaticMethod(false, jbossVFS, "getMount",
root.getClass(), root);
if (mount == null) return null;

// try to access the fileSystem of the mount. Type is org.jboss.vfs.spi.FileSystem
Object fileSystem = classpathOrderOut.reflectionUtils.invokeMethod(false, mount, "getFileSystem");
if (fileSystem == null) return null;

// now access the mount source, which is the file that is used to create the mount.
File mountSource = (File) classpathOrderOut.reflectionUtils.invokeMethod(false, fileSystem,
"getMountSource");
if (mountSource == null) return null;

// absolute path of the mountSource should be the 'physical' .jar
return mountSource.getAbsolutePath();
}

/**
* Get the access to the JBoss VFS class. Tries to load VFS first from the classloader of the provided root object
* if it's an object from org.jboss.vfs.
* If the root object is not from org.jboss.vfs, VFS will be tried to be loaded from the current thread class loader.
* It might be unnecessary to load VFS from the current thread context, because this means that the root object
* is not from org.jboss.vfs and VFS will not help here... but as a defensive approach we really try to get VFS
* access here.
*
* @param root The root VirtualFile of JBoss VFS. Used to load the VFS via the classloader of the root. Can not be null.
* @return The Class object representing the JBoss VFS class, or null if it couldn't be found.
*/
private static Class<?> getJBossVFSAccess( final Object root) {
Class<?> jbossVFS = null;
// we need access to the class 'VFS' of org.jboss.vfs
try {
if(root.getClass().getName().contains("org.jboss.vfs")) {
// first, try the classloader of the root object. Since the root object comes from org.jboss.vfs,
// it is likely that we can get access to org.jboss.vfs.VFS from this classloader
ClassLoader vfsRootClassloader= root.getClass().getClassLoader();
jbossVFS = loadJBossVFS(vfsRootClassloader);
}else {
// for non org.jboss.vfs objects, use the currentThread
jbossVFS = loadJBossVFS(Thread.currentThread().getContextClassLoader());
}
} catch (ClassNotFoundException e) {
try {
// try to load JBoss VFS access from the current threads classloader since the previous method failed
// if the previous method was already the currentThreads classloader, it will fail again...
jbossVFS = loadJBossVFS(Thread.currentThread().getContextClassLoader());
} catch (ClassNotFoundException e1) {
// swallow the exception. If there is no VFS present, we can't do anything...
}
}
return jbossVFS;
}

private static Class<?> loadJBossVFS(ClassLoader classLoader) throws ClassNotFoundException {
return Class.forName("org.jboss.vfs.VFS", true, classLoader);
}

/**
* Returns the absolute path of a JAR file from a given root object using the 'classic' VFS read mechanism.
* This works for Versions of JBoss/Wildfly prior to this change:
* <a href="https://issues.redhat.com/browse/WFLY-18544">WFLY-18544</a>
* <a href="https://issues.redhat.com/browse/JBEAP-25879">JBEAP-25879</a>
* <a href="https://issues.redhat.com/browse/JBEAP-25677">JBEAP-25677</a>
* @param root The root object to get the JAR path from.
* @param classpathOrderOut The ClasspathOrder object for updating the classpath order.
* @return The absolute path of the JAR file, or null if the path couldn't be found.
*/
private static String loadJarPathFromClassicVFS(final Object root, final ClasspathOrder classpathOrderOut) {
String path = null;
// type VirtualFile
final File physicalFile = (File) classpathOrderOut.reflectionUtils.invokeMethod(false, root,
"getPhysicalFile");
String path = null;
if (physicalFile != null) {
final String name = (String) classpathOrderOut.reflectionUtils.invokeMethod(false, root, "getName");
if (name != null) {
Expand All @@ -134,20 +257,8 @@ private static void handleResourceLoader(final Object resourceLoader, final Clas
}
}
}
if (path == null) {
final File file = (File) classpathOrderOut.reflectionUtils.getFieldVal(false, resourceLoader,
"fileOfJar");
if (file != null) {
path = file.getAbsolutePath();
}
}
if (path != null) {
classpathOrderOut.addClasspathEntry(path, classLoader, scanSpec, log);
} else {
if (log != null) {
log.log("Could not determine classpath for ResourceLoader: " + resourceLoader);
}
}

return path;
}

/**
Expand All @@ -167,8 +278,8 @@ private static void handleResourceLoader(final Object resourceLoader, final Clas
* the log
*/
private static void handleRealModule(final Object module, final Set<Object> visitedModules,
final ClassLoader classLoader, final ClasspathOrder classpathOrderOut, final ScanSpec scanSpec,
final LogNode log) {
final ClassLoader classLoader, final ClasspathOrder classpathOrderOut, final ScanSpec scanSpec,
final LogNode log) {
if (!visitedModules.add(module)) {
// Avoid extracting paths from the same module more than once
return;
Expand Down Expand Up @@ -209,7 +320,7 @@ private static void handleRealModule(final Object module, final Set<Object> visi
* the log.
*/
public static void findClasspathOrder(final ClassLoader classLoader, final ClasspathOrder classpathOrder,
final ScanSpec scanSpec, final LogNode log) {
final ScanSpec scanSpec, final LogNode log) {
final Object module = classpathOrder.reflectionUtils.invokeMethod(false, classLoader, "getModule");
final Object callerModuleLoader = classpathOrder.reflectionUtils.invokeMethod(false, module,
"getCallerModuleLoader");
Expand Down

0 comments on commit 053ed8d

Please sign in to comment.