-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in enableSystemJarsAndModules behaviour #658
Comments
Hey @cushon, I took a look at this, and there is another issue in addition to the one you pointed out -- currently the accept/reject logic doesn't work the same for modules as it does for packages etc. (Specifically if you mark at least one module for scanning using I think I need to revamp the whole accept/reject system, since this is needed to fix #643 too. It might take me a while to do this. I'm glad you have found a workaround for this, for the meantime. However thinking more specifically about your question, I'm not sure if the old behavior that you were used to (where even if Maybe the right thing to do is to have ClassGraph automatically call |
Thanks for taking a look! I don't really have an opinion about the best approach here.
That would be convenient, but is there a good way to detecting which module and package names are system ones, without doing the work |
Correct, I'd have to detect module name prefixes |
The following demo used to be able to find classes in
jdk.compiler
, but it fails with recent versions of classgraph.The change bisects to 718bcba.
Adding
.enableSystemJarsAndModules()
allows it to work with the latest version of classgraph.I'm fine with passing
enableSystemJarsAndModules()
, I just wanted to double-check if this was an expected result of that change?The text was updated successfully, but these errors were encountered: