Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some issues with dot graph generation where it would throw null… #189

Merged
merged 1 commit into from
Apr 14, 2018

Conversation

seanrl
Copy link

@seanrl seanrl commented Apr 11, 2018

…ptrs if you tried to enable field or method info. Also modified the dot graph generation algorithm to generate UML-like nodes when field or method info are enabled

…ptrs if you tried to enable field or method info. Also modified the dot graph generation algorithm to generate UML-like nodes when field or method info are enabled
@seanrl
Copy link
Author

seanrl commented Apr 12, 2018

If users like this feature (I do), it could probably use some tweaks here and there. The UML significantly increases the size of the graphs, so that can also be a problem.

@lukehutch lukehutch merged commit 4f416e7 into classgraph:master Apr 14, 2018
@lukehutch
Copy link
Member

Thank you @seanrl, this is probably really useful. There are a few changes I'll need to make, e.g. I'm trying hard not to add any additional dependencies, so I'll have to add a custom HTML escape function. I probably have to put the UML generation behind a Boolean parameter or something. But I really appreciate the additions and the bugfixes!

@lukehutch
Copy link
Member

@seanrl I added a bunch more features (display of annotations, etc.), made some Graphviz formatting improvements, and I'm releasing the result as 2.18.2. Check out the output from that version. Thanks again!

@lukehutch
Copy link
Member

PS re. the UML increasing the size of graphs -- the way to fix that is to not call .enableMethodInfo() and/or .enableFieldInfo(). I may need to add more fine-grained controls if the graph sizes are problematic for people.

@seanrl
Copy link
Author

seanrl commented May 2, 2018

Hey @lukehutch thanks for accepting and expanding the capability. I'll check out the new version soon. Even with the expanded size of generated UML diagrams, I've had pretty good luck with some optional parameters in GraphViz's sfdp and neato programs. Thanks for the info, and looking forward to checking out the annotations and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants