Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OSGi metadata to existing projects without changing the packag… #84

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Conversation

johnou
Copy link
Contributor

@johnou johnou commented Oct 3, 2016

…ing type.

@johnou
Copy link
Contributor Author

johnou commented Oct 3, 2016

@bertramn PTAL.

@bertramn
Copy link

bertramn commented Oct 3, 2016

Looks good, dropped it into Karaf 4 and bundle comes up nicely. The only optimisation would be to consider if any of the packages can be considered "internal" use and excluded from export. But by the looks of it there is at least 1 class one would typically use in each package (not that this matters much TBH).

@johnou
Copy link
Contributor Author

johnou commented Oct 3, 2016

@lukehutch I think we are good to go :)

@lukehutch
Copy link
Member

Thanks, @johnou . @bertramn , you could exclude the utils subpackage if you would like, those classes are all for internal use. I suspect you don't feel too strongly about this based on your comment "not that this matters much TBH", so I'll merge this PR now -- feel free to submit another one if you want to exclude utils from export.

@lukehutch lukehutch merged commit 0e2b140 into classgraph:master Oct 4, 2016
@lukehutch
Copy link
Member

Released in version 2.0.4.

@johnou johnou deleted the feature/osgi branch October 4, 2016 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants