feat(feeshare): Developer Incentives #144

Reecepbcups · 2023-02-23T01:43:30Z

This PR is in replace of #75 & builds on main properly

This reverts commit d5bb6e1.

custom/auth/ante/ante.go

x/feeshare/ante/expected_keepers.go

custom/auth/ante/ante.go

proto/terra/feeshare/v1beta1/genesis.proto

ZaradarBH

Great job m8 and gz on the lead dev role @ Juno :)

x/feeshare/ante/ante.go

x/feeshare/client/cli/tx.go

fragwuerdig · 2023-03-11T17:20:51Z

Do NOT merge this branch @ZaradarBH, @nghuyenthevinh2000, @Reecepbcups: Something is going on. I tried different environments to run this branch - failed. There is some runtime issue going on with this feature. The nodes wont start on genesis transactions.

nghuyenthevinh2000 · 2023-03-11T17:55:17Z

Do NOT merge this branch @ZaradarBH, @nghuyenthevinh2000, @Reecepbcups: Something is going on. I tried different environments to run this branch - failed. There is some runtime issue going on with this feature. The nodes wont start on genesis transactions.

thanks you so much for testing this out, what is the log?

fragwuerdig · 2023-03-11T19:05:42Z

@Reecepbcups @ZaradarBH @nghuyenthevinh2000 @inon-man: In app.go beginning at line 522 we have the following snippet:

app.mm.SetOrderInitGenesis( capabilitytypes.ModuleName, authtypes.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, slashingtypes.ModuleName, govtypes.ModuleName, markettypes.ModuleName, oracletypes.ModuleName, treasurytypes.ModuleName, wasmtypes.ModuleName, authz.ModuleName, minttypes.ModuleName, crisistypes.ModuleName, ibchost.ModuleName, genutiltypes.ModuleName, evidencetypes.ModuleName, ibctransfertypes.ModuleName, feegrant.ModuleName, feesharetypes.ModuleName )

This must be replaced by the following snippet:

app.mm.SetOrderInitGenesis( feesharetypes.ModuleName, capabilitytypes.ModuleName, authtypes.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, slashingtypes.ModuleName, govtypes.ModuleName, markettypes.ModuleName, oracletypes.ModuleName, treasurytypes.ModuleName, wasmtypes.ModuleName, authz.ModuleName, minttypes.ModuleName, crisistypes.ModuleName, ibchost.ModuleName, genutiltypes.ModuleName, evidencetypes.ModuleName, ibctransfertypes.ModuleName, feegrant.ModuleName )

This moves the feesharetypes.ModuleName up in the SetOrderInitGenesis. After setting higher priority for genesis initialization of the feeshare module the node should start normally on genesis (tested it locally, produced some blocks).

It might very well be that the liveness test fails nevertheless. But then its not because the node fails to start up but rather because expanding the local testnet from 4 to 6 nodes introduced a bug with this test. I guess, we should work on it in another branch.

Btw: Do we need migration handler for this? On the mainnet the parameter space for this is not yet initialized, or is it?

Another question: Why is only one workflow (snyk test) running on this branch?

fragwuerdig · 2023-03-11T19:57:55Z

thanks you so much for testing this out, what is the log?

@nghuyenthevinh2000: The nodes simply did not start up on genesis:

Resolved with:

#144 (comment)

ZaradarBH · 2023-03-12T00:33:50Z

Do NOT merge this branch @ZaradarBH, @nghuyenthevinh2000, @Reecepbcups: Something is going on. I tried different environments to run this branch - failed. There is some runtime issue going on with this feature. The nodes wont start on genesis transactions.

@Reecepbcups @ZaradarBH @nghuyenthevinh2000 @inon-man: In app.go beginning at line 522 we have the following snippet:

app.mm.SetOrderInitGenesis( capabilitytypes.ModuleName, authtypes.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, slashingtypes.ModuleName, govtypes.ModuleName, markettypes.ModuleName, oracletypes.ModuleName, treasurytypes.ModuleName, wasmtypes.ModuleName, authz.ModuleName, minttypes.ModuleName, crisistypes.ModuleName, ibchost.ModuleName, genutiltypes.ModuleName, evidencetypes.ModuleName, ibctransfertypes.ModuleName, feegrant.ModuleName, feesharetypes.ModuleName )

This must be replaced by the following snippet:

app.mm.SetOrderInitGenesis( feesharetypes.ModuleName, capabilitytypes.ModuleName, authtypes.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, slashingtypes.ModuleName, govtypes.ModuleName, markettypes.ModuleName, oracletypes.ModuleName, treasurytypes.ModuleName, wasmtypes.ModuleName, authz.ModuleName, minttypes.ModuleName, crisistypes.ModuleName, ibchost.ModuleName, genutiltypes.ModuleName, evidencetypes.ModuleName, ibctransfertypes.ModuleName, feegrant.ModuleName )

This moves the feesharetypes.ModuleName up in the SetOrderInitGenesis. After setting higher priority for genesis initialization of the feeshare module the node should start normally on genesis (tested it locally, produced some blocks).

It might very well be that the liveness test fails nevertheless. But then its not because the node fails to start up but rather because expanding the local testnet from 4 to 6 nodes introduced a bug with this test. I guess, we should work on it in another branch.

Btw: Do we need migration handler for this? On the mainnet the parameter space for this is not yet initialized, or is it?

Another question: Why is only one workflow (snyk test) running on this branch?

@fragwuerdig , nice find m8! I think the workflow issue might be because the PR branch belongs to an external org, it might be messing with the GH action configuration. Havnt looked into it.

FYI I created an issue for the liveliness bug so we can all look into that together next week. #171

fragwuerdig · 2023-03-13T10:34:15Z

@Reecepbcups I have another commit for this branch (merging main into this branch to resolve conflicts). I don't know exactly why I could push ed35c8c. But it's clear that I cannot push anymore... Do you changed any permissions on your forked repo? Can you allow me to push commits?

Reecepbcups · 2023-03-14T00:22:36Z

@fragwuerdig Thanks for this! I missed running a local instance I got so caught up in my Juno upgrade.

Can confirm the reordering works

I did not change any permissions no. I have allow edits by maintainers on and have not touched anything since this PR was opened. So unless this org changed permissions, not sure why this is the case

nghuyenthevinh2000

Code looks good and best to merge this after sdk 45 upgrade

ZaradarBH · 2023-03-27T14:07:35Z

@Reecepbcups any chance you can find time to bring this branch up-2-date with main so we can merge the PR after the 2.0 release? :)

This reverts commit 1e7936c.

Co-authored-by: nghuyenthevinh2000 <nghuyenthevinh@gmail.com> Co-authored-by: Till Ziegler <tz@schoeneweide.tk> Co-authored-by: vincent <vincent.ch.cn@gmail.com> Co-authored-by: chengwenxi <22697326+chengwenxi@users.noreply.github.com> Co-authored-by: alchemist-ti <134163224+alchemist-ti@users.noreply.github.com>

Reecepbcups added 12 commits February 22, 2023 18:50

add wasm feeshare module (Needs upgradeHandler, e2e test)

1c3d25a

change names from juno -> terra classic

694883f

adds feeshare to app.go

5db0a43

ante, antetest, regen feeshare proto

d5bb6e1

FeeShare Ante & testing (breaks right now)

c131fa6

Revert "ante, antetest, regen feeshare proto"

a7ae73b

This reverts commit d5bb6e1.

NewKVStoreKeys & upgrade

c96fd2c

fix test-node bash

57a1f1c

fix test node pt 2

ae35280

add in feehshareante, still not working hmm

97b7b15

remove duplicate test

f6fdd31

fix duplicate import ante test

8498eb3

ZaradarBH reviewed Feb 23, 2023

View reviewed changes

custom/auth/ante/ante.go Show resolved Hide resolved

custom/auth/ante/ante.go Outdated Show resolved Hide resolved

x/feeshare/ante/expected_keepers.go Show resolved Hide resolved

ZaradarBH assigned Reecepbcups Feb 23, 2023

ZaradarBH added enhancement New feature or request out of scope work that is unapproved by the community, but still essential for the L1 team labels Feb 23, 2023

ZaradarBH added this to the Proposal 11168 milestone Feb 23, 2023

ZaradarBH self-assigned this Feb 23, 2023

Reecepbcups and others added 2 commits February 23, 2023 12:20

SendCoinsFromModuleToModule, custom bank type

c7eb092

Couldnt sleep.... this seems to fix the problem :)

babe847

ZaradarBH reviewed Feb 24, 2023

View reviewed changes

custom/auth/ante/ante.go Outdated Show resolved Hide resolved

proto/terra/feeshare/v1beta1/genesis.proto Show resolved Hide resolved

proto/terra/feeshare/v1beta1/genesis.proto Show resolved Hide resolved

ZaradarBH added 5 commits February 24, 2023 05:59

Genesis & Params simulation plumbing

049ce61

Add //#nosec to math/rand imports

4b5f1b9

Specific nosec ignore code (G404)

8724208

Add exclude-rule for G404

9b64754

Fixed indentation issue in yml

0778afb

nghuyenthevinh2000 changed the base branch from main to feeshare February 24, 2023 10:19

nghuyenthevinh2000 changed the base branch from feeshare to main February 24, 2023 10:20

nghuyenthevinh2000 added 2 commits February 24, 2023 18:23

fix feeshare simulation

d1ecc13

remove txt

d7a462c

Reecepbcups added 2 commits February 27, 2023 13:29

move proto Params up

edfa038

use custom/auth/ante bank keeper

6a504a6

ZaradarBH approved these changes Mar 1, 2023

View reviewed changes

nghuyenthevinh2000 reviewed Mar 9, 2023

View reviewed changes

x/feeshare/ante/ante.go Show resolved Hide resolved

x/feeshare/client/cli/tx.go Outdated Show resolved Hide resolved

ZaradarBH added 4 commits March 11, 2023 14:41

Added [withdraw_bech32] to NewUpdateFeeShare cmd

1b2551f

Added TestFeeSharePayout

058f8af

Finalized simple test for FeeSharePayoutDecorator

1b02fd0

Added MsgExecuteContract to tx

747da27

ZaradarBH requested a review from nghuyenthevinh2000 March 11, 2023 14:40

move feeshare genesis initialization up in priority

ed35c8c

ZaradarBH requested a review from fragwuerdig March 12, 2023 00:34

Merge branch main into reece/feeshare2

8b8874a

nghuyenthevinh2000 approved these changes Mar 16, 2023

View reviewed changes

Reecepbcups added 5 commits March 27, 2023 15:45

Merge branch 'main' into reece/feeshare2

5e88dde

Minor fixes from main for feeshare

a3fa04b

Auto fix feeshare lint

4e13743

gofmt

3c6bebd

final lint

e8b724f

ZaradarBH merged commit 1e7936c into classic-terra:main Mar 29, 2023

aeuser999 mentioned this pull request May 6, 2023

[BUG] Server Cannot Sync #216

Closed

inon-man added a commit that referenced this pull request Jun 17, 2023

Revert "feat(feeshare): Developer Incentives (#144)"

6cb7458

This reverts commit 1e7936c.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(feeshare): Developer Incentives #144

feat(feeshare): Developer Incentives #144

Reecepbcups commented Feb 23, 2023 •

edited

ZaradarBH left a comment •

edited

fragwuerdig commented Mar 11, 2023

nghuyenthevinh2000 commented Mar 11, 2023

fragwuerdig commented Mar 11, 2023 •

edited

fragwuerdig commented Mar 11, 2023 •

edited

ZaradarBH commented Mar 12, 2023 •

edited

fragwuerdig commented Mar 13, 2023

Reecepbcups commented Mar 14, 2023 •

edited

nghuyenthevinh2000 left a comment

ZaradarBH commented Mar 27, 2023

feat(feeshare): Developer Incentives #144

feat(feeshare): Developer Incentives #144

Conversation

Reecepbcups commented Feb 23, 2023 • edited

ZaradarBH left a comment • edited

Choose a reason for hiding this comment

fragwuerdig commented Mar 11, 2023

nghuyenthevinh2000 commented Mar 11, 2023

fragwuerdig commented Mar 11, 2023 • edited

fragwuerdig commented Mar 11, 2023 • edited

ZaradarBH commented Mar 12, 2023 • edited

fragwuerdig commented Mar 13, 2023

Reecepbcups commented Mar 14, 2023 • edited

nghuyenthevinh2000 left a comment

Choose a reason for hiding this comment

ZaradarBH commented Mar 27, 2023

Reecepbcups commented Feb 23, 2023 •

edited

ZaradarBH left a comment •

edited

fragwuerdig commented Mar 11, 2023 •

edited

fragwuerdig commented Mar 11, 2023 •

edited

ZaradarBH commented Mar 12, 2023 •

edited

Reecepbcups commented Mar 14, 2023 •

edited