Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate staking #241

Merged
merged 5 commits into from May 31, 2023
Merged

migrate staking #241

merged 5 commits into from May 31, 2023

Conversation

alchemist-ti
Copy link
Contributor

@alchemist-ti alchemist-ti commented May 30, 2023

Summary of changes

Closes: #109, after merging the canonical-wasm branch, it will be rebased to the main branch.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@alchemist-ti alchemist-ti requested review from nghuyenthevinh2000 and fragwuerdig and removed request for nghuyenthevinh2000 May 30, 2023 10:49
Comment on lines +19 to +22
// to run staking store migration
stakingKeeper := keepers.StakingKeeper
stkingMigrator := keeper.NewMigrator(stakingKeeper)
stkingMigrator.Migrate13to14(ctx)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In classic-terra/cosmos-sdk, the ConsensusVersion of the Staking module is not incremented in order to keep it consistent with cosmos/cosmos-sdk, so it is different from common module migrations.

Copy link
Member

@nghuyenthevinh2000 nghuyenthevinh2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the script and confirmed working. LGTM

Screenshot 2023-05-31 at 12 16 44

@fragwuerdig fragwuerdig merged commit 301b9c4 into canonical-wasm May 31, 2023
14 of 15 checks passed
@alchemist-ti alchemist-ti deleted the migrate-staking branch May 31, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants