Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): add legacy wasm types #259

Merged
merged 8 commits into from Jun 21, 2023
Merged

Conversation

nghuyenthevinh2000
Copy link
Member

@nghuyenthevinh2000 nghuyenthevinh2000 commented Jun 15, 2023

Summary of changes

Closes: #256
Closes: #258

Other .pb.go files changes are due to linting

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@fragwuerdig
Copy link
Collaborator

fragwuerdig commented Jun 16, 2023

@nghuyenthevinh2000: I wanna still test with LCD tonight using curl. Will probably add it to the upgrade test script. Thank you.

@inon-man

This comment was marked as resolved.

inon-man

This comment was marked as resolved.

@inon-man inon-man changed the title add legacy wasm types feat(wasm): add legacy wasm types Jun 17, 2023
@fragwuerdig

This comment was marked as resolved.

@nghuyenthevinh2000

This comment was marked as resolved.

@inon-man inon-man added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Jun 21, 2023
@inon-man

This comment was marked as resolved.

@inon-man inon-man changed the title feat(wasm): add legacy wasm types fix(wasm): add legacy wasm types Jun 21, 2023
@nghuyenthevinh2000 nghuyenthevinh2000 merged commit 7d59142 into main Jun 21, 2023
16 checks passed
@nghuyenthevinh2000 nghuyenthevinh2000 deleted the v2.1.x/fix-legacy-codec branch June 21, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
5 participants