Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic commission acc seq fix #386

Merged
merged 5 commits into from Nov 26, 2023
Merged

add dynamic commission acc seq fix #386

merged 5 commits into from Nov 26, 2023

Conversation

nghuyenthevinh2000
Copy link
Member

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

types/fork/fork.go Outdated Show resolved Hide resolved
@basitalikhoso110
Copy link

fix-dyncomm

Copy link
Collaborator

@fragwuerdig fragwuerdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good from my side.

My suggestion would be to introduce a "legacy" dyncomm ante decorator that only runs the dyncomm ante handler for "<" specified block height. The normal one would run for ">=" specified block height.

This way the chain could be forked without explicitly halting the chain.

@StrathCole
Copy link
Collaborator

I think that looks good from my side.

My suggestion would be to introduce a "legacy" dyncomm ante decorator that only runs the dyncomm ante handler for "<" specified block height. The normal one would run for ">=" specified block height.

This way the chain could be forked without explicitly halting the chain.

I think the validators complained about not having a proposal for notifying them about the update, so maybe a proposal with chain halt is the best way to make sure they all see it.

@nghuyenthevinh2000 nghuyenthevinh2000 merged commit a0a38c3 into main Nov 26, 2023
16 checks passed
@nghuyenthevinh2000 nghuyenthevinh2000 deleted the fix-dyncomm branch November 26, 2023 09:36
expertdicer pushed a commit to Genuine-labs/terra-classic that referenced this pull request Jan 28, 2024
expertdicer pushed a commit to Genuine-labs/terra-classic that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants