stricter constraint that fails unqualified commission at check tx #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragwuerdig
approved these changes
Nov 28, 2023
expertdicer
pushed a commit
to Genuine-labs/terra-classic
that referenced
this pull request
Jan 28, 2024
expertdicer
pushed a commit
to Genuine-labs/terra-classic
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Check tx skipped in dyncomm decorator will broadcast failed txs to other nodes, thus posing a potential risk. This pr seeks to stricten the rule in ante decorator.
Full e2e test case is refactored in place of old EditValidatorAccountSequence with blocks simulation to ensure checktx and delivertx accSeq invariant when failed.
Report of required housekeeping
(FOR ADMIN) Before merging