-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm upgrade from main #67
Conversation
I find the gas used by wasmvm after upgrade to v1.0.0 is pretty staggering. I put a quick comparison between v0.16.6 and v1.0.0 gas consumption here:
that is x10000 |
@nghuyenthevinh2000 did you adjust the default gas multiplier in this branch? Please look in my original #49 and try to cherry pick as much as you can from there. Old gas multiplier was 100. New one is about 140,000,000. |
I find this very interesting actually. Like, why wasmvm just increases its gas price so huge like that. |
I really want to bring our x/wasm closer to CosmWasm x/wasm so that one day we can just use x/wasm and save us from the pain of maintaining this module. After comparing the two, I realize that there are a lot of functions with same functionality but different name. |
@nghuyenthevinh2000 so you are suggesting to refactor towards wasmd implementation? We can definitely work on that. Could we have a separate issue for that an just focus on getting the upgrade done for now? Or do you think refactoring should be done asap? |
Overtime I would say, right now, I am trying to get the testing code of wasmd into ours. |
Need to fix the broken tests :) |
…he for BenchmarkInstantiationOverhead
I have been playing around with gas to try to see if it can be calculated. The wasmVM gas calculation behaves differently from last version. After understanding the flow of gas calculation in wasmVM, my conclusion is that however wasmVM behaves we should only concern about GasMultiplier. Name of the game: guess GasMultiplier so that it breaks as less test as possible.
Because they check for exact gas which will always break everytime GasMultiplier is changed. I find that GasMultiplier = 15_000_000 breaks the least amount of gas test |
I will write a separate pr for wasm upgrade testing |
Summary of changes
Clean updating wasm from main branch.
cc: @fragwuerdig
This is work from: #49
Change:
Report of required housekeeping
(FOR ADMIN) Before merging