Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizelton Caravan Update #686

Closed
wants to merge 4 commits into from
Closed

Gizelton Caravan Update #686

wants to merge 4 commits into from

Conversation

Zingzah
Copy link
Contributor

@Zingzah Zingzah commented Dec 21, 2014

This is a first pass to upgrading the current Gizelton Caravan event in Desolace. I have looked on many cores and can't find a working version of this on any at the moment. I have used a few sources as well as personal experience in configuring the bahaviour of the caravan at various stages. The sources are
http://www.wowwiki.com/Gizelton_Caravan
http://www.wowwiki.com/Quest:Gizelton_Caravan
https://www.youtube.com/watch?v=VtOREFq5fDQ
https://www.youtube.com/watch?v=VtOREFq5fDQ
http://www.wowhead.com/npc=11625/cork-gizelton#comments
http://www.wowhead.com/npc=12246#comments
http://www.wowhead.com/npc=12245#comments
http://www.wowwiki.com/Schematic:_Accurate_Scope
http://www.wowwiki.com/Schematic:_Ice_Deflector
http://www.wowwiki.com/Goblin_Jumper_Cables
super_seller
super_seller2

Currently the caravan travels endlessly between Kormek's Hut and the southern crossroads where the paths to Feralas, Shadowprey Village and Mannoroc Coven meet. At Kormek's Hut the Vendor-tron 1000 is spawned continously as is the Super-seller 680 at the southern stop. Both Cork and Rigger have available, at all times, the "Bodyguards for Hire" and "Gizelton Caravan" quests which when accepted, do nothing.
So the changes listed below will achieve the following:

  1. Set the movement type of both vendor-tron 1000 (12245) and Super-seller 680(12246) to stationary.
  2. Adjust the waypoints at both ends of the journey to coincide more accurately with the stopping points for both ends.
  3. As mentioned in the wowwiki entry for the Gizelton Caravan quest, the caravan's usual movement is running and during the escort for each quest it slows to walking speed.
  4. Configuring the Vendor-tron and Super-seller to spawn only during the stopping times of the caravan at either end and then despawn once the caravan has departed.
  5. Set stopping points for both Bodyguards for Hire and Gizelton Caravan quests where the caravan waits for quest acceptance and set the relevent advertising zone-wide yell for these quests.
  6. Move both waypoints for Cork and Rigger Gizelton from the creature_movement table to the creature_movement_template table as these are unique npcs.
  7. Configure the quest for each npc to only be available at the respective waiting points.
  8. To remove items from the Super-seller that should not be available from this vendor.ie Accurate Scope, Goblin Jumper Cables and Ice Deflector schematics
  9. Waiting times at northern and southern stops is 10 mins. Departing emotes are said 10 seconds prior. Waiting times at quest acceptance stops is 5 mins.

There are a few issues this upgrade does not address and include:

  1. The escort script for both quests needs to completed. I wasn't sure if db scripts could achieve this or whether it needs to be done through SD2.
  2. The current core prevents the caravan from completing the journey autonomously without player proximity. However comments listed above (wowhead entries) indicate the caravan behaving differently in proximity to players than out of range. Having read a recent post in the forums about active objects/npcs, this might be a solution to this issue.
  3. I haven't been able to remove the quest option from Cork or Rigger when they are the northern or southern stopping points. This needs to be achieved as the respective quests should only be available at the advertised points along the route.
  4. This is a general issue not specific to the caravan but I have noticed npcs can't be healed or buffed in many escort quests. The youtube videos above clearly show this should be possible.

Database Changes
Cork Gizelton (template entry 12245 guid 28714)
Rigger Gizelton (template entry 12246 guid 28728)
Gizelton Caravan Kodo (template entry 11564 guid 27290 (front) 27289 (back))
Vendor-tron 1000 (template entry 12245)
Super-seller 680 (template entry 12246)
creature_movement

Please only consider the last commit [852] - Gizelton Caravan the others are dry runs I haven't work out how to get rid of from my local repo.

Zingzah added 4 commits December 21, 2014 21:52
Includes updates to
*Northern and Southern stop points
*Quest stop points
*Superseller and Vendortron spawning and items
*Quest availability
This reverts commit b13f701.
Includes updates to
*Northern and Southern stop points
*Quest stop points
*Super-seller 680 and Vendortron 1000 spawning and items
*Bodyguards for Hire and Gizelton Caravan Quest availability
@cala
Copy link
Member

cala commented Dec 22, 2014

Thank you for this nice pull request. Reflexion on these two quests is also done on SD2 side and they were wondering if all could be handle by DB or if SD2 was partly or totally needed. So I will link the two discussions to make them both move forward.

I will also let that Pull Request open until a decision is made. Anyway, nice work thank you! 👍

@Rushor
Copy link

Rushor commented Mar 15, 2015

could you link the points of the movement in the script where the quest should be completed?

@cala
Copy link
Member

cala commented Nov 26, 2015

@xfurry and @Zingzah FYI, I will start working on this soon (this week or the next) and link it with the SD2 issue.

@Rushor
Copy link

Rushor commented Nov 26, 2015

wonderful :)

@Zingzah
Copy link
Contributor Author

Zingzah commented Dec 18, 2015

Thanks Cala. I've been wanting to revisit this event and have a go at the script for both quests. Just finishing up something atm.

@Rushor
Copy link

Rushor commented Dec 18, 2015

keep up this wonderful work - i love you for this :)

@cala cala closed this in 936a9f2 Jan 3, 2016
cala added a commit that referenced this pull request Sep 9, 2016
* Added script support and miscellaneous fixes to the Gizelton Caravan
in Desolace
The caravan will now stop 10 min at each end of its path (north, and
south) and one of the twi Gizelton brother will spawn a specific vendor
NPC at those points
The caravan will also wait for 5 min soon after departing to give
players the opportunity to take the escort quests
Thanks @Rushor for researching and provinding data
Thanks @Zingzah for researching, provinding data and doing a lot of
preliminary work, some of them are included in this fix
This closes #686
offl added a commit to TrinityCore/TrinityCore that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants