Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: h5p initial integration attempt #27

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Conversation

jankapunkt
Copy link
Member

Summary

Implements H5P basic interaction types. WIP until the checklist is complete!

  • content types can be loaded from server and listet using Templates instead of the H5P Hub
  • selected content types can open the editor
  • editor is styled with claire theme
  • items are displayed in task preview in task editor
  • items are displayed in task preview in unit editor
  • items are displayed in task preview in lesson
  • items are displayed in student's task view
  • item responses are sent and stored on the server in the respective collection


//decodes html entities
var elem = document.createElement('textarea');
elem.innerHTML = solutions[i];

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
if (parameters && parameters.text) {
extras = extras || {};
extras.metadata = extras.metadata || {};
extras.metadata.title = parameters.text.replace(/<[^>]*>?/g, '');

Check failure

Code scanning / CodeQL

Incomplete multi-character sanitization High

This string may still contain
<script
, which may cause an HTML element injection vulnerability.
@jankapunkt jankapunkt merged commit 185d950 into master Jan 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant