This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
Fatal error when cron runs because $product is null #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to err out. This prevents the fatal error. This may only be happening on our development environments due to messy data, but I added this code so I could get your module through our internal QA process. I'm not sure if it's the best fix, but it worked for what I needed. I've starred your repo so that I get notified of any future changes that need to be applied. Thanks for the great work on this!
|
@TonyDeStefano Thanks for this code, but we'll have to take a slightly different approach to ensure that tax is still captured for the order item when the product is missing. I'm going to close this PR and future updates will be posted to your open issue #104, since that looks to be related. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes getOrderItem()->getProduct() returns null and causes the cron to err out. This prevents the fatal error.
This may only be happening on our development environments due to messy data, but I added this code so I could get your module through our internal QA process. I'm not sure if it's the best fix, but it worked for what I needed. I've starred your repo so that I get notified of any future changes that need to be applied. Thanks for the great work on this!