Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Build and push amd/arm OCI images #17

Merged
merged 2 commits into from
May 26, 2022

Conversation

ptx96
Copy link
Contributor

@ptx96 ptx96 commented May 25, 2022

Closes #16

Before merging this:

  • test the amd64 image
  • create quay.io / docker.io kamaji repositories
  • create BOT_QUAY_IO, BOT_DOCKER_IO, USER_DOCKER_IO secrets

I will test the armX images later

EDIT: arm64 image tested inside Oracle Cloud Ampere region, it works!

@ptx96 ptx96 requested a review from prometherion May 25, 2022 18:30
@ptx96 ptx96 added the enhancement New feature or request label May 25, 2022
@prometherion
Copy link
Member

@ptx96 secrets on GitHub cannot contain dots, going for underscores if you don't mind.

@ptx96
Copy link
Contributor Author

ptx96 commented May 26, 2022

@ptx96 secrets on GitHub cannot contain dots, going for underscores if you don't mind.

My bad @prometherion , it was a typo!
Use underscores for sure

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we're going to use the following secrets:

QUAY_IO_USERNAME
QUAY_IO_TOKEN
DOCKER_IO_USERNAME
DOCKER_IO_TOKEN

Please, use the new naming convention.

@ptx96 ptx96 requested a review from prometherion May 26, 2022 14:36
@ptx96 ptx96 marked this pull request as ready for review May 26, 2022 15:22
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you think we should give it a try to test the whole workflow?

@ptx96
Copy link
Contributor Author

ptx96 commented May 26, 2022

LGTM, do you think we should give it a try to test the whole workflow?

Already did that in my fork actions: https://github.com/ptx96/kamaji/runs/6590146018?check_suite_focus=true

Results:

https://quay.io/repository/ptx96/kamaji?tab=tags
https://hub.docker.com/repository/docker/ptx96/kamaji/tags?page=1&ordering=last_updated

I already tested the arm64 image with success

LMK if you need other tests

@prometherion prometherion merged commit 6cebf09 into clastix:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GH workflow for OCI image build and push
2 participants