Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add test suite for e2e #34

Merged
merged 2 commits into from
May 28, 2022
Merged

Conversation

alegrey91
Copy link
Contributor

Fix #14

e2e/tenant_control_plane_ready_test.go Outdated Show resolved Hide resolved
e2e/tenant_control_plane_ready_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@alegrey91 alegrey91 force-pushed the master branch 3 times, most recently from 5e62508 to 144dd08 Compare May 27, 2022 16:07
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to the convention for binaries without the suffix -install.

Makefile Outdated Show resolved Hide resolved
@alegrey91 alegrey91 force-pushed the master branch 3 times, most recently from cb30927 to a283c8e Compare May 28, 2022 09:41
@prometherion
Copy link
Member

@alegrey91 I saw a bug we got on master branch when installing with Helm:

1.6537308490105534e+09  ERROR   controller.tenantcontrolplane   Reconciler error        {"reconciler group": "kamaji.clastix.io", "reconciler kind": "TenantControlPlane", "name": "tenant-test", "namespace": "kamaji-system", "error": "error updating tenantControlPlane status: TenantControlPlane.kamaji.clastix.io \"tenant-test\" is invalid: [status.kubeadmPhase.addonCoreDNS: Required value, status.kubeadmPhase.addonKubeProxy: Required value]"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

Let me fix that on master

@alegrey91
Copy link
Contributor Author

@prometherion I just increased the timeout to 5 mins

@prometherion
Copy link
Member

@alegrey91 it's not a matter of timeout, your failing tests are due to #35, please rebase over master since the fix has been merged and force push.

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funky Gallo approves it! 🐓

@prometherion prometherion merged commit 0dbd736 into clastix:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up e2e test suite
2 participants