fix(certificate_lifecycle_controller): blocking reconciliation in case of error #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
MathieuCesbron
force-pushed
the
clean_controllers_get_resource
branch
from
fbb977a
to
118041d
Compare
MathieuCesbron
force-pushed
the
clean_controllers_get_resource
branch
from
118041d
to
81806d4
Compare
prometherion
changed the title
Signed-off-by: Mathieu Cesbron <mathieu.cesbron@protonmail.com>
MathieuCesbron
force-pushed
the
clean_controllers_get_resource
branch
from
81806d4
to
2188a11
Compare
prometherion
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to clean the controller Get logic and error handling.