Addons #7
Merged
Addons #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+101
to
+104
| // +kubebuilder:default={enabled: true} | ||
| CoreDNS AddonSpec `json:"coreDNS,omitempty"` | ||
| // +kubebuilder:default={enabled: true} | ||
| KubeProxy AddonSpec `json:"kubeProxy,omitempty"` |
There was a problem hiding this comment.
Are these defaults required although specified in TenantControlPlaneSpec.Addons struct key?
There was a problem hiding this comment.
It is a still WIP and I am figuring out how to deal with the default values.
mendrugory
force-pushed
the
gonzalo/addons
branch
3 times, most recently
from
3d1c314
to
3512f27
Compare
mendrugory
force-pushed
the
gonzalo/addons
branch
2 times, most recently
from
0d9fdf3
to
5108b0c
Compare
prometherion
requested changes
May 25, 2022
mendrugory
force-pushed
the
gonzalo/addons
branch
from
5108b0c
to
d0ad534
Compare
mendrugory
force-pushed
the
gonzalo/addons
branch
from
d0ad534
to
7abf13b
Compare
prometherion
approved these changes
May 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will try to customize how to allow addons (Kubeadm addons) for a provisioned tenant control plane.