Skip to content

Commit

Permalink
Coverage changes in tests module
Browse files Browse the repository at this point in the history
- login_user is never used on a single user
- `var is None` is the preferred style for testing for `None`
- Migrations should not be included in test coverage
- Updated codecov action to latest version
  • Loading branch information
moggers87 committed Aug 30, 2021
1 parent 0439c21 commit 48a611f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .coveragerc
Expand Up @@ -3,6 +3,8 @@ branch = True
source =
tests
two_factor
omit =
*/migrations/*

[report]
exclude_lines =
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Expand Up @@ -26,11 +26,10 @@ jobs:
- name: Generate coverage XML report
run: coverage xml
- name: Codecov
uses: codecov/codecov-action@v1.0.10
uses: codecov/codecov-action@v2.0.3
env:
PYTHON: ${{matrix.python-version}}
with:
fail_ci_if_error: true
env_vars: PTYHON


Expand Down
7 changes: 3 additions & 4 deletions tests/utils.py
Expand Up @@ -27,9 +27,8 @@ def create_superuser(self, username='bouke@example.com', password='secret', **kw
self._passwords[user] = password
return user

def login_user(self, user=None):
if not user:
user = list(self._passwords.keys())[0]
def login_user(self):
user = list(self._passwords.keys())[0]
username = user.get_username()
assert self.client.login(username=username, password=self._passwords[user])
if default_device(user):
Expand All @@ -38,6 +37,6 @@ def login_user(self, user=None):
session.save()

def enable_otp(self, user=None):
if not user:
if user is None:
user = list(self._passwords.keys())[0]
return user.totpdevice_set.create(name='default')

0 comments on commit 48a611f

Please sign in to comment.