Skip to content

Commit

Permalink
Fixed #20224 -- Update docs examples which mention __unicode__
Browse files Browse the repository at this point in the history
  • Loading branch information
claudep committed Jul 4, 2013
1 parent c5bc98d commit 31b741c
Show file tree
Hide file tree
Showing 24 changed files with 65 additions and 24 deletions.
2 changes: 1 addition & 1 deletion django/contrib/gis/management/commands/ogrinspect.py
Expand Up @@ -53,7 +53,7 @@ class Command(LabelCommand):
make_option('--multi-geom', action='store_true', dest='multi_geom', default=False,
help='Treat the geometry in the data source as a geometry collection.'),
make_option('--name-field', dest='name_field',
help='Specifies a field name to return for the `__unicode__` function.'),
help='Specifies a field name to return for the `__unicode__`/`__str__` function.'),
make_option('--no-imports', action='store_false', dest='imports', default=True,
help='Do not include `from django.contrib.gis.db import models` '
'statement.'),
Expand Down
5 changes: 3 additions & 2 deletions django/contrib/gis/utils/ogrinspect.py
Expand Up @@ -89,7 +89,7 @@ def ogrinspect(*args, **kwargs):
`multi_geom` => Boolean (default: False) - specify as multigeometry.
`name_field` => String - specifies a field name to return for the
`__unicode__` function (which will be generated if specified).
`__unicode__`/`__str__` function (which will be generated if specified).
`imports` => Boolean (default: True) - set to False to omit the
`from django.contrib.gis.db import models` code from the
Expand Down Expand Up @@ -221,4 +221,5 @@ def get_kwargs_str(field_name):

if name_field:
yield ''
yield ' def __str__(self): return self.%s' % name_field
yield ' def __%s__(self): return self.%s' % (
'str' if six.PY3 else 'unicode', name_field)
6 changes: 3 additions & 3 deletions docs/howto/custom-model-fields.txt
Expand Up @@ -696,9 +696,9 @@ smoothly:
behavior of the field code is to call
:func:`~django.utils.encoding.force_text` on the value. (In our
examples in this document, ``value`` would be a ``Hand`` instance, not a
``HandField``). So if your ``__unicode__()`` method automatically
converts to the string form of your Python object, you can save yourself
a lot of work.
``HandField``). So if your ``__unicode__()`` method (``__str__`` on Python 3)
automatically converts to the string form of your Python object, you can save
yourself a lot of work.


Writing a ``FileField`` subclass
Expand Down
5 changes: 4 additions & 1 deletion docs/internals/contributing/writing-code/coding-style.txt
Expand Up @@ -124,13 +124,16 @@ Model style
first_name = models.CharField(max_length=20)
last_name = models.CharField(max_length=40)

* If you define a ``__str__`` method (previously ``__unicode__`` before Python 3
was supported), decorate the model class with
:func:`~django.utils.encoding.python_2_unicode_compatible`.

* The order of model inner classes and standard methods should be as
follows (noting that these are not all required):

* All database fields
* Custom manager attributes
* ``class Meta``
* ``def __unicode__()``
* ``def __str__()``
* ``def save()``
* ``def get_absolute_url()``
Expand Down
2 changes: 2 additions & 0 deletions docs/intro/overview.txt
Expand Up @@ -31,6 +31,7 @@ the file ``mysite/news/models.py``::
class Reporter(models.Model):
full_name = models.CharField(max_length=70)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.full_name

Expand All @@ -40,6 +41,7 @@ the file ``mysite/news/models.py``::
content = models.TextField()
reporter = models.ForeignKey(Reporter)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.headline

Expand Down
1 change: 1 addition & 0 deletions docs/ref/contrib/admin/actions.txt
Expand Up @@ -57,6 +57,7 @@ simple news application with an ``Article`` model::
body = models.TextField()
status = models.CharField(max_length=1, choices=STATUS_CHOICES)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.title

Expand Down
5 changes: 3 additions & 2 deletions docs/ref/contrib/admin/index.txt
Expand Up @@ -438,7 +438,8 @@ subclass::
list_display = ('first_name', 'last_name')

If you don't set ``list_display``, the admin site will display a single
column that displays the ``__unicode__()`` representation of each object.
column that displays the ``__unicode__()`` (``__str__()`` on Python 3)
representation of each object.

You have four possible values that can be used in ``list_display``:

Expand Down Expand Up @@ -488,7 +489,7 @@ subclass::
A few special cases to note about ``list_display``:

* If the field is a ``ForeignKey``, Django will display the
``__unicode__()`` of the related object.
``__unicode__()`` (``__str__()`` on Python 3) of the related object.

* ``ManyToManyField`` fields aren't supported, because that would
entail executing a separate SQL statement for each row in the table.
Expand Down
1 change: 1 addition & 0 deletions docs/ref/contrib/contenttypes.txt
Expand Up @@ -270,6 +270,7 @@ A simple example is a tagging system, which might look like this::
object_id = models.PositiveIntegerField()
content_object = generic.GenericForeignKey('content_type', 'object_id')

# On Python 3: def __str__(self):
def __unicode__(self):
return self.tag

Expand Down
4 changes: 2 additions & 2 deletions docs/ref/contrib/gis/commands.txt
Expand Up @@ -65,8 +65,8 @@ of using ``ogrinspect`` :ref:`in the tutorial <ogrinspect-intro>`.

.. django-admin-option:: --name-field <name_field>

Generates a ``__unicode__`` routine on the model that will return the
the given field name.
Generates a ``__unicode__`` routine (``__str__`` on Python 3) on the model
that will return the the given field name.

.. django-admin-option:: --no-imports

Expand Down
2 changes: 2 additions & 0 deletions docs/ref/contrib/gis/layermapping.txt
Expand Up @@ -60,6 +60,8 @@ Example
name = models.CharField(max_length=25) # corresponds to the 'str' field
poly = models.PolygonField(srid=4269) # we want our model in a different SRID
objects = models.GeoManager()

# On Python 3: def __str__(self):
def __unicode__(self):
return 'Name: %s' % self.name

Expand Down
1 change: 1 addition & 0 deletions docs/ref/contrib/gis/tutorial.txt
Expand Up @@ -244,6 +244,7 @@ model to represent this data::
objects = models.GeoManager()

# Returns the string representation of the model.
# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand Down
3 changes: 2 additions & 1 deletion docs/ref/forms/api.txt
Expand Up @@ -566,7 +566,8 @@ Customizing the error list format

By default, forms use ``django.forms.util.ErrorList`` to format validation
errors. If you'd like to use an alternate class for displaying errors, you can
pass that in at construction time::
pass that in at construction time (replace ``__unicode__`` by ``__str__`` on
Python 3)::

>>> from django.forms.util import ErrorList
>>> class DivErrorList(ErrorList):
Expand Down
12 changes: 6 additions & 6 deletions docs/ref/forms/fields.txt
Expand Up @@ -1000,12 +1000,12 @@ objects (in the case of ``ModelMultipleChoiceField``) into the
initial value, no empty choice is created (regardless of the value
of ``empty_label``).

The ``__unicode__`` method of the model will be called to generate
string representations of the objects for use in the field's choices;
to provide customized representations, subclass ``ModelChoiceField``
and override ``label_from_instance``. This method will receive a model
object, and should return a string suitable for representing it. For
example::
The ``__unicode__`` (``__str__`` on Python 3) method of the model will be
called to generate string representations of the objects for use in the
field's choices; to provide customized representations, subclass
``ModelChoiceField`` and override ``label_from_instance``. This method will
receive a model object, and should return a string suitable for representing
it. For example::

from django.forms import ModelChoiceField

Expand Down
6 changes: 6 additions & 0 deletions docs/ref/models/instances.txt
Expand Up @@ -430,6 +430,12 @@ Other model instance methods

A few object methods have special purposes.

.. note::
On Python 3, as all strings are natively considered Unicode, only use the
``__str__()`` method, which entirely obsoletes the ``__unicode__()`` method.
If you'd like compatibility with Python 2, you can decorate your model class
with :func:`~django.utils.encoding.python_2_unicode_compatible`.

``__unicode__``
---------------

Expand Down
1 change: 1 addition & 0 deletions docs/ref/models/querysets.txt
Expand Up @@ -817,6 +817,7 @@ For example, suppose you have these models::
name = models.CharField(max_length=50)
toppings = models.ManyToManyField(Topping)

# On Python 3: def __str__(self):
def __unicode__(self):
return u"%s (%s)" % (self.name, u", ".join([topping.name
for topping in self.toppings.all()]))
Expand Down
6 changes: 4 additions & 2 deletions docs/ref/utils.txt
Expand Up @@ -446,12 +446,14 @@ Atom1Feed
def fancy_utility_function(s, ...):
# Do some conversion on string 's'
...
# Replace unicode by str on Python 3
fancy_utility_function = allow_lazy(fancy_utility_function, unicode)

The ``allow_lazy()`` decorator takes, in addition to the function to decorate,
a number of extra arguments (``*args``) specifying the type(s) that the
original function can return. Usually, it's enough to include ``unicode`` here
and ensure that your function returns only Unicode strings.
original function can return. Usually, it's enough to include ``unicode``
(or ``str`` on Python 3) here and ensure that your function returns only
Unicode strings.

Using this decorator means you can write your function and assume that the
input is a proper string, then add support for lazy translation objects at the
Expand Down
1 change: 1 addition & 0 deletions docs/topics/auth/customizing.txt
Expand Up @@ -967,6 +967,7 @@ authentication app::
# The user is identified by their email address
return self.email

# On Python 3: def __str__(self):
def __unicode__(self):
return self.email

Expand Down
2 changes: 2 additions & 0 deletions docs/topics/class-based-views/generic-display.txt
Expand Up @@ -89,6 +89,7 @@ We'll be using these models::
class Meta:
ordering = ["-name"]

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand All @@ -98,6 +99,7 @@ We'll be using these models::
email = models.EmailField()
headshot = models.ImageField(upload_to='author_headshots')

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand Down
2 changes: 2 additions & 0 deletions docs/topics/db/examples/many_to_many.txt
Expand Up @@ -16,6 +16,7 @@ objects, and a ``Publication`` has multiple ``Article`` objects:
class Publication(models.Model):
title = models.CharField(max_length=30)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.title

Expand All @@ -26,6 +27,7 @@ objects, and a ``Publication`` has multiple ``Article`` objects:
headline = models.CharField(max_length=100)
publications = models.ManyToManyField(Publication)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.headline

Expand Down
8 changes: 5 additions & 3 deletions docs/topics/db/examples/many_to_one.txt
Expand Up @@ -15,6 +15,7 @@ To define a many-to-one relationship, use :class:`~django.db.models.ForeignKey`.
last_name = models.CharField(max_length=30)
email = models.EmailField()

# On Python 3: def __str__(self):
def __unicode__(self):
return u"%s %s" % (self.first_name, self.last_name)

Expand All @@ -23,6 +24,7 @@ To define a many-to-one relationship, use :class:`~django.db.models.ForeignKey`.
pub_date = models.DateField()
reporter = models.ForeignKey(Reporter)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.headline

Expand Down Expand Up @@ -56,9 +58,9 @@ Article objects have access to their related Reporter objects::

>>> r = a.reporter

These are strings instead of unicode strings because that's what was used in
the creation of this reporter (and we haven't refreshed the data from the
database, which always returns unicode strings)::
On Python 2, these are strings instead of unicode strings because that's what
was used in the creation of this reporter (and we haven't refreshed the data
from the database, which always returns unicode strings)::

>>> r.first_name, r.last_name
('John', 'Smith')
Expand Down
3 changes: 3 additions & 0 deletions docs/topics/db/examples/one_to_one.txt
Expand Up @@ -16,6 +16,7 @@ In this example, a ``Place`` optionally can be a ``Restaurant``:
name = models.CharField(max_length=50)
address = models.CharField(max_length=80)

# On Python 3: def __str__(self):
def __unicode__(self):
return u"%s the place" % self.name

Expand All @@ -24,13 +25,15 @@ In this example, a ``Place`` optionally can be a ``Restaurant``:
serves_hot_dogs = models.BooleanField()
serves_pizza = models.BooleanField()

# On Python 3: def __str__(self):
def __unicode__(self):
return u"%s the restaurant" % self.place.name

class Waiter(models.Model):
restaurant = models.ForeignKey(Restaurant)
name = models.CharField(max_length=50)

# On Python 3: def __str__(self):
def __unicode__(self):
return u"%s the waiter at %s" % (self.name, self.restaurant)

Expand Down
7 changes: 6 additions & 1 deletion docs/topics/db/models.txt
Expand Up @@ -416,13 +416,15 @@ something like this::
class Person(models.Model):
name = models.CharField(max_length=128)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

class Group(models.Model):
name = models.CharField(max_length=128)
members = models.ManyToManyField(Person, through='Membership')

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand Down Expand Up @@ -709,7 +711,10 @@ of :ref:`methods automatically given to each model <model-instance-methods>`.
You can override most of these -- see `overriding predefined model methods`_,
below -- but there are a couple that you'll almost always want to define:

:meth:`~Model.__unicode__`
:meth:`~Model.__str__` (Python 3)
Python 3 equivalent of ``__unicode__()``.

:meth:`~Model.__unicode__` (Python 2)
A Python "magic method" that returns a unicode "representation" of any
object. This is what Python and Django will use whenever a model
instance needs to be coerced and displayed as a plain string. Most
Expand Down
3 changes: 3 additions & 0 deletions docs/topics/db/queries.txt
Expand Up @@ -23,13 +23,15 @@ models, which comprise a Weblog application:
name = models.CharField(max_length=100)
tagline = models.TextField()

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

class Author(models.Model):
name = models.CharField(max_length=50)
email = models.EmailField()

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand All @@ -44,6 +46,7 @@ models, which comprise a Weblog application:
n_pingbacks = models.IntegerField()
rating = models.IntegerField()

# On Python 3: def __str__(self):
def __unicode__(self):
return self.headline

Expand Down
1 change: 1 addition & 0 deletions docs/topics/forms/modelforms.txt
Expand Up @@ -162,6 +162,7 @@ Consider this set of models::
title = models.CharField(max_length=3, choices=TITLE_CHOICES)
birth_date = models.DateField(blank=True, null=True)

# On Python 3: def __str__(self):
def __unicode__(self):
return self.name

Expand Down

0 comments on commit 31b741c

Please sign in to comment.