Fixed bug when KeyboardSensor can fully scroll a single axis

Fixed a bug in the `KeyboardSensor` where it would not move the draggable on the horizontal axis if it could fully scroll to the new vertical coordinates, and would not move the draggable on the vertical axis if it could fully scroll to the new horizontal coordinates.
clauderic · May 21, 2022 · 750d726 · 750d726
1 parent 33e6dd2
commit 750d726
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/keyboard-sensor-bug.md b/.changeset/keyboard-sensor-bug.md
@@ -0,0 +1,5 @@
+---
+'@dnd-kit/core': patch
+---
+
+Fixed a bug in the `KeyboardSensor` where it would not move the draggable on the horizontal axis if it could fully scroll to the new vertical coordinates, and would not move the draggable on the vertical axis if it could fully scroll to the new horizontal coordinates.
diff --git a/packages/core/src/sensors/keyboard/KeyboardSensor.ts b/packages/core/src/sensors/keyboard/KeyboardSensor.ts
@@ -176,7 +176,7 @@ export class KeyboardSensor implements SensorInstance {
               (direction === KeyboardCode.Left &&
                 newScrollCoordinates >= minScroll.x);
 
-            if (canFullyScrollToNewCoordinates) {
+            if (canFullyScrollToNewCoordinates && !coordinatesDelta.y) {
               // We don't need to update coordinates, the scroll adjustment alone will trigger
               // logic to auto-detect the new container we are over
               scrollContainer.scrollTo({
@@ -205,7 +205,7 @@ export class KeyboardSensor implements SensorInstance {
               (direction === KeyboardCode.Up &&
                 newScrollCoordinates >= minScroll.y);
 
-            if (canFullyScrollToNewCoordinates) {
+            if (canFullyScrollToNewCoordinates && !coordinatesDelta.x) {
               // We don't need to update coordinates, the scroll adjustment alone will trigger
               // logic to auto-detect the new container we are over
               scrollContainer.scrollTo({