Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace useReducer with useState #1435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knaveenkumar3576
Copy link

@knaveenkumar3576 knaveenkumar3576 commented Jun 12, 2024

This PR includes three changes:

useDroppable function: Changed useIsomorphicLayoutEffect to useEffect
Although setting state in a layout effect is useful for measuring the DOM, in this case, it only registers droppable elements during the first render. It can wait until later without causing any UI flickers.

useRect function: Replaced useReducer with useState.
Switched to useState because useReducer causes nested updates due to the lack of a bailout mechanism.

useRects function: Replaced useReducer with useState.
Switched to useState because useReducer causes nested updates due to the lack of a bailout mechanism .

Please review @clauderic

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 5a72450

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@knaveenkumar3576 knaveenkumar3576 marked this pull request as ready for review June 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant