Exclude fixed position node's ancestors from getScrollableAncestors #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #61 and #298 (any others?) positioning doesn't work as expected when the
DndContext
is inside a fixed position container.This small change (preventing
getScrollableAncestors
from continuing to search if a fixed position node is found) seems to resolve the issues I had, but there may be some nuance I'm missing and I only tested it with my own project.