Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue in days or years panel on page load until scroll is initiated #23

Closed
Ruzo opened this issue Jun 23, 2016 · 5 comments
Closed
Labels

Comments

@Ruzo
Copy link

Ruzo commented Jun 23, 2016

Kind of a newbie here but did not see this issue mentioned anywhere.

On page load and reload, when display="days", the days' panel is blank or half-filled when the min date is more than a few months apart than the selectedDate (even in the basic configuration).
Same as when display="years" but the min and selectedDate need to be about 20 years apart.

The '.Grid__cell' divs seem to be pushed down past the ' .Grid__innerScrollContainer'.

When you start scrolling, it starts displaying from the min date. It seems like the display does not get positioned to the selectedDate. It also considers selectedDate="null" as the default date in this behavior.

Here are some screenshots:
infinite_calendar_issue
infinite_calendar_issue_years

@clauderic clauderic added the bug label Jun 29, 2016
@clauderic
Copy link
Owner

At first sight, this appears to be a bug with scrollbars and newer versions of https://github.com/bvaughn/react-virtualized/, I'll follow-up when I know more / find a solution

@bvaughn
Copy link

bvaughn commented Jun 29, 2016

@clauderic and I chatted about this in Gitter and a guard for this edge-case (scrollTop being set before CSS styles have loaded) has been added to react-virtualized Grid. This has been released via 7.11.5.

@bvaughn
Copy link

bvaughn commented Jun 29, 2016

npm i react-virtualized@7.11.5 --save and try again?

@clauderic
Copy link
Owner

Just published 1.1.15 which is updated to use the latest version of react-virtualized

@Ruzo
Copy link
Author

Ruzo commented Jun 30, 2016

Sorry I missed the replies. Thanks for the fix. Works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants