Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Displaying events #6

Open
marek-sed opened this issue Jun 1, 2016 · 18 comments
Open

[Feature] Displaying events #6

marek-sed opened this issue Jun 1, 2016 · 18 comments
Assignees
Labels

Comments

@marek-sed
Copy link

Hi,

Is there a way to display states like birthday, federal holidays, events on each day?

@clauderic
Copy link
Owner

clauderic commented Jun 1, 2016

I think the best way to go about this would be to provide a custom day renderer function and a custom selected state renderer. This would allow for maximal flexibility. Thoughts?

@marek-sed
Copy link
Author

marek-sed commented Jun 1, 2016

yes I was thinking something like that. Basically looking at date component at it is written now,
it has 2 parts. Wrapper Component that handles click events and disabled state, and creates data needed for display component. And Display Component, which receives the needed data, and handles state('selected', 'normal'). So it would be nice if user can provide this custom display component.

What do you think?

I can implement it on weekend, if you want I need this exact functionality in my app so I can test it there.

@clauderic
Copy link
Owner

I have a pretty good idea of how I would implement it, but I'm curious to see how you would implement it. How about you take a first stab at it and we'll take it from there :)

@marek-sed
Copy link
Author

Yeah thats sounds like a good plan :)

@clauderic clauderic mentioned this issue Jun 3, 2016
@kennetpostigo
Copy link

@clauderic @marek-sed it would be pretty neat if there was a tool-tip shown when an event is hovered on or clicked on. What do you guys think?

@sandysaders
Copy link

@marek-sed @clauderic what is the status on this?

@clauderic
Copy link
Owner

clauderic commented Jun 11, 2016

Haven't heard back from @marek-sed, I'll get around to tackling this next week or so. Tooltip would be nice for sure, but I'm probably going to build the logic for this to be as abstract as possible and then provide a couple of example recipes

@marek-sed
Copy link
Author

marek-sed commented Jun 11, 2016

Hi @clauderic @jamestwiggle , sry I went silent, was quite busy.
I just issued the pull request for this.

EDIT: and broke a bunch of tests, fixing it now :)
EDIT: fixed

@shikelong
Copy link

when can you release the new npm package that merged this pull request ?

Regards. @clauderic

@clauderic
Copy link
Owner

I'll take a look at it next week, I'm currently on vacation :)

@hiddenl00p
Copy link

@clauderic I understand this may be your side project, but do you know when you will be able to support this?

@pinder360
Copy link

@clauderic any update on this?

@clauderic clauderic changed the title display custom states(events) for each day [Feature]: Displaying events Feb 25, 2017
@clauderic clauderic changed the title [Feature]: Displaying events [Feature] Displaying events Feb 25, 2017
@oyeanuj
Copy link

oyeanuj commented Mar 1, 2017

@marek-sed @clauderic Also curious if this is on any one of your radar still?

@clauderic
Copy link
Owner

clauderic commented Mar 1, 2017

This would be fairly simple to implement with the new architecture of react-infinite-calendar@^2.0.0.

This isn't something I have bandwidth to work on at the moment, but if this is something you're interested in, you can take a look at the implementation of the withMultipleDates HOC: https://github.com/clauderic/react-infinite-calendar/blob/master/src/Calendar/withMultipleDates.js.

I think the implementation for displaying events would be fairly similar.

@offsky
Copy link
Contributor

offsky commented Mar 1, 2017

I would be happy to take a stab at this, but Im new to recompose, so I could use a little help coming up to speed. Can someone please explain what this line does from the above mentioned file?

withProps(({displayDate, onSelect, setDisplayDate, scrollToDate, ...props}) => ({

I think I understand that it is doing something magical to inject props into the secret wrapper container around Calendar. Im not quite sure where those 5 arguments come from and where they are going. In particular, where is "scrollToDate" defined? Thanks!

@arecvlohe
Copy link

@offsky He is using destructuring to select the props that are coming before it and modifying them in some way before passing them to the wrapped component. I hope that helps.

mo4islona pushed a commit to mo4islona/react-infinite-calendar that referenced this issue Jul 14, 2018
…on-text-align

Fixed year range selection start and end month text align
@awb99
Copy link

awb99 commented Jul 23, 2018

Is it possible to display events now? The pull request is there, but is it merged?

@daiky00
Copy link

daiky00 commented Oct 25, 2018

@marek-sed @clauderic @Makashov is this already possible? please tell me is ready! it has been two years waiting on this feature and we are in version 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests