Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for having the helper stay in the list's bounds #21

Closed
zaygraveyard opened this issue Jun 22, 2016 · 6 comments
Closed

Add support for having the helper stay in the list's bounds #21

zaygraveyard opened this issue Jun 22, 2016 · 6 comments

Comments

@zaygraveyard
Copy link
Contributor

zaygraveyard commented Jun 22, 2016

Currently only it's half is inside the list.

I can submit a PR if needed.

@clauderic
Copy link
Owner

Can you elaborate? Not sure what you're referring to

@zaygraveyard
Copy link
Contributor Author

if you go to the lock axis demo page and try to drag an item above the list, that item will be half inside and half outside of the list.

@zaygraveyard
Copy link
Contributor Author

Here's a snapshot
image

@clauderic
Copy link
Owner

clauderic commented Jun 22, 2016

This is by design. Why exactly is it a problem? Do you have a use case in mind?

@zaygraveyard
Copy link
Contributor Author

This is by design.

That's why this is a feature request and not a bug report ;)

Why exactly is it a problem? Do you have a use case in mind?

I would like to have the option to restrict the dragging of the items to the strict bounds of their container.

Thank you

@clauderic
Copy link
Owner

Hmm. Fair enough. I'm busy tackling other more urgent bugs, but feel free to submit a PR if you feel strongly about this 👍

zaygraveyard added a commit to zaygraveyard/react-sortable-hoc that referenced this issue Jun 22, 2016
zaygraveyard added a commit to zaygraveyard/react-sortable-hoc that referenced this issue Jun 23, 2016
zaygraveyard added a commit to zaygraveyard/react-sortable-hoc that referenced this issue Jun 24, 2016
zaygraveyard added a commit to zaygraveyard/react-sortable-hoc that referenced this issue Jun 24, 2016
zaygraveyard added a commit to zaygraveyard/react-sortable-hoc that referenced this issue Jun 24, 2016
DimitarNestorov pushed a commit to codemotionapps/react-sortable-hoc that referenced this issue Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants