Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressDelay should only affect touch events #363

Open
reichertm opened this issue Apr 3, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@reichertm
Copy link

commented Apr 3, 2018

pressDelay affects both mouse click and touch events. It works really well on touch devices but it does not feel natural with a mouse device. You expect to be able to drag an item with a mouse instantly and it doesn't seem to be easily discoverable that you are supposed to click and hold for a duration of time before being able to drag. Perhaps pressDelay setting should only affect touch devices. There it is useful to avoid accidental reorder on scrolling.

@towfiqi

This comment has been minimized.

Copy link

commented May 4, 2018

Sorry. I disagree. We have a web app that lets you click item to get full view and also drag it around . It helps that there is a delay before dragging. Otherwise the clickevent is very wonky..

@vince1995

This comment has been minimized.

Copy link

commented Oct 17, 2018

Workaround: Detect if it's a touch device and set only pressDelay if it is.

llevequeblup added a commit to myblup/react-sortable-hoc that referenced this issue Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.