Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Scrolling With Firefox Under Windows/Ubuntu #7

Merged
merged 3 commits into from Apr 29, 2017

Conversation

Magnitus-
Copy link

@Magnitus- Magnitus- commented Apr 21, 2017

... and some other edge cases.

Inspiration for the fix was drawn from this merge request in react-virtualized: bvaughn/react-virtualized#110

@codecov
Copy link

codecov bot commented Apr 21, 2017

Codecov Report

Merging #7 into master will decrease coverage by 1.19%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
- Coverage   92.85%   91.66%   -1.2%     
=========================================
  Files           3        3             
  Lines         140      144      +4     
=========================================
+ Hits          130      132      +2     
- Misses         10       12      +2
Impacted Files Coverage Δ
src/constants.js 100% <100%> (ø) ⬆️
src/index.js 84.21% <25%> (-3.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aa453...d76d839. Read the comment docs.

@clauderic
Copy link
Owner

Hey @Magnitus-,

Thanks for submitting this PR!

I'll try to set aside a bit of time to dive in and test this fix sometime today, but this looks great at a glance 👍

@Magnitus-
Copy link
Author

Magnitus- commented Apr 26, 2017

Sure. Take your time, there is no rush. Let me know if you'd like any adjustments to the PR and thank you for this project. It's great.

@clauderic clauderic merged commit 1a07b70 into clauderic:master Apr 29, 2017
@clauderic
Copy link
Owner

Thanks for this contribution @Magnitus-! Just had a few stylistic/linting nitpicks, but otherwise this is perfect.

Just shipped this fix with 2.0.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants