-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fb message types #115
Feature/fb message types #115
Conversation
Feature/update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the things looks ok. One question: as message type is required, why don't we set it to "RESPONSE" as default value and allow users to change it with methods you provided?
lib/facebook/format-message.js
Outdated
'FEATURE_FUNCTIONALITY_UPDATE', 'TICKET_UPDATE']; | ||
|
||
const includes_polyfill = require('../utils/includes-polyfill'); | ||
includes_polyfill(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, but I don't think we should include 50+ lines polyfill when we can use indexOf
, can you please remove the polyfill and replace includes
with indexOf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair points. I'll make the changes and update.
lgtm, thanks! |
Welcome!
ᐧ
…On Wed, Apr 25, 2018 at 12:46 AM, Slobodan Stojanović < ***@***.***> wrote:
lgtm, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKE6MqNFYjv0ItnE7Zk1JjE6wU63Ddtuks5tsCnsgaJpZM4TahiU>
.
|
As of May 7, 2018, Facebook is requiring that all messages sent to Messenger include
messaging_type
. This branch includes support for this change as well as support for includingmessage_tag
; although it does not specifically throw an error if someone attempts to send a message without themessaging_type
field.Spec files (facebook-format-message-spec.js and facebook-reply-spec.js) have been updated to test these changes and all tests are passing.