Feature/fb message types #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/update docs
stojanovic
reviewed
Apr 24, 2018
lib/facebook/format-message.js
Outdated
| 'FEATURE_FUNCTIONALITY_UPDATE', 'TICKET_UPDATE']; | ||
|
|
||
| const includes_polyfill = require('../utils/includes-polyfill'); | ||
| includes_polyfill(); |
There was a problem hiding this comment.
This is nice, but I don't think we should include 50+ lines polyfill when we can use indexOf, can you please remove the polyfill and replace includes with indexOf?
There was a problem hiding this comment.
Fair points. I'll make the changes and update.
stojanovic
approved these changes
Apr 25, 2018
|
lgtm, thanks! |
|
Welcome!
ᐧ
…On Wed, Apr 25, 2018 at 12:46 AM, Slobodan Stojanović < ***@***.***> wrote:
lgtm, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKE6MqNFYjv0ItnE7Zk1JjE6wU63Ddtuks5tsCnsgaJpZM4TahiU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of May 7, 2018, Facebook is requiring that all messages sent to Messenger include
messaging_type. This branch includes support for this change as well as support for includingmessage_tag; although it does not specifically throw an error if someone attempts to send a message without themessaging_typefield.Spec files (facebook-format-message-spec.js and facebook-reply-spec.js) have been updated to test these changes and all tests are passing.