Allow to configure which hooks to run

claudiu-cristea · May 21, 2024 · ee7707e · ee7707e
1 parent 39091f2
commit ee7707e
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 1 deletion.
diff --git a/resources/config/config.yml b/resources/config/config.yml
@@ -20,6 +20,7 @@ services:
             - '%hooks_dir%'
             - '%hooks_preset%'
             - '%git_hook_variables%'
+            - '%git_hooks%'
     GrumPHP\Configuration\Model\ParallelConfig:
         factory: ['GrumPHP\Configuration\Model\ParallelConfig', 'fromArray']
         arguments:

diff --git a/src/Configuration/Configuration.php b/src/Configuration/Configuration.php
@@ -4,6 +4,7 @@
 
 namespace GrumPHP\Configuration;
 
+use GrumPHP\Console\Command\Git\InitCommand;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
@@ -70,6 +71,14 @@ public function getConfigTreeBuilder(): TreeBuilder
         $ascii->children()->variableNode('failed')->defaultValue('grumphp-grumpy.txt');
         $ascii->children()->variableNode('succeeded')->defaultValue('grumphp-happy.txt');
 
+        $rootNode->children()->arrayNode('git_hooks')->defaultValue(InitCommand::$hooks)
+            ->prototype('scalar')
+                ->validate()
+                    ->ifNotInArray(InitCommand::$hooks)
+                    ->thenInvalid('Invalid item %s')
+                ->end()
+            ->end();
+
         // parallel
         $parallel = $rootNode->children()->arrayNode('parallel');
         $parallel->canBeDisabled();

diff --git a/src/Configuration/Model/HooksConfig.php b/src/Configuration/Model/HooksConfig.php
@@ -27,7 +27,8 @@ class HooksConfig
     public function __construct(
         ?string $dir,
         string $preset,
-        array $variables
+        array $variables,
+        private array $gitHooks,
     ) {
         $this->dir = $dir;
         $this->preset = $preset;
@@ -48,4 +49,9 @@ public function getVariables(): array
     {
         return $this->variables;
     }
+
+    public function getGitHooks(): array
+    {
+        return $this->gitHooks;
+    }
 }
diff --git a/src/Console/Command/Git/DeInitCommand.php b/src/Console/Command/Git/DeInitCommand.php
@@ -22,6 +22,7 @@ class DeInitCommand extends Command
      */
     protected static $hooks = [
         'pre-commit',
+        'pre-push',
         'commit-msg',
     ];
 

diff --git a/src/Console/Command/Git/InitCommand.php b/src/Console/Command/Git/InitCommand.php
@@ -27,6 +27,7 @@ class InitCommand extends Command
      */
     public static $hooks = [
         'pre-commit',
+        'pre-push',
         'commit-msg',
     ];
 
@@ -100,6 +101,9 @@ public function execute(InputInterface $input, OutputInterface $output): int
         }
 
         foreach (self::$hooks as $hook) {
+            if (!in_array($hook, $this->hooksConfig->getGitHooks(), true)) {
+                continue;
+            }
             $gitHook = $this->filesystem->buildPath($gitHooksPath, $hook);
             $hookTemplate = $this->filesystem->guessFile(
                 [