Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadPage returns zeroed array in ultralight.go #6

Closed
graynk opened this issue Apr 30, 2019 · 4 comments
Closed

ReadPage returns zeroed array in ultralight.go #6

graynk opened this issue Apr 30, 2019 · 4 comments

Comments

@graynk
Copy link
Contributor

graynk commented Apr 30, 2019

https://github.com/fuzxxl/freefare/blob/0db9bd4463f361189042156563572f0517fa7b9c/0.3/freefare/ultralight.go#L63-L68

It should be return data, nil here. I could keep track of any issues that may arise as I work my way through my project that uses this wrapper, and then make a PR with all the fixes I end up with, so as not to spam with any more issues, if that's okay with you.

@clausecker
Copy link
Owner

Thank you for reporting this issue! Making one huge pull request is probably a good idea. I do not really work on this project anymore, but I'm happy to accept reasonable pull requests.

@clausecker
Copy link
Owner

Did you end up finishing your project? If yes, I would definitely still appreciate a pull request.

@graynk
Copy link
Contributor Author

graynk commented Apr 29, 2020

It kind of got stuck in the middle because management didn't know if they wanted to use ultralight tags or not and then I changed workplaces, so I don't actually work with hardware anymore. But I did end up fixing a few bugs and used pretty much all of Ultralight's functionality in my prototype complete with key derivation, so I will try to dig it up and make a PR over the weekend!

@clausecker
Copy link
Owner

Thanks a lot! Your help is very valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants