add exitCode

estr.js

@@ -53,6 +53,7 @@ switch (process.argv.shift()) {
 
           console.error("parse error in "+results[0].sourcefile
                        ,results[0].parseError);
+          exitCode(1);
 
         } else if (results[0].decls){
 
@@ -67,6 +68,7 @@ switch (process.argv.shift()) {
         } else {
 
           console.error('unknown result',results[0]);
+          exitCode(1);
 
         }
       }
@@ -112,14 +114,17 @@ switch (process.argv.shift()) {
 
           console.error("parse error in "+results[0].sourcefile
                        ,results[0].parseError);
+          exitCode(1);
 
         } else if (results[0].error) {
 
           console.error(results[0].error.message);
+          exitCode(1);
 
         } else {
 
           console.error('unknown result',results[0]);
+          exitCode(1);
 
         }
       }
@@ -170,14 +175,17 @@ switch (process.argv.shift()) {
 
           console.error("parse error in "+results[0].sourcefile
                        ,results[0].parseError);
+          exitCode(1);
 
         } else if (results[0].error) {
 
           console.error(results[0].error.message);
+          exitCode(1);
 
         } else {
 
           console.error('unknown result',results[0]);
+          exitCode(1);
 
         }
       }
@@ -207,7 +215,6 @@ function processJSfiles(paths,action) {
   return results;
 }
 
-function updateFile(action) { return function(path,source) {
-  var newSource = action(path,source);
-  fs.writeFileSync(path,newSource);
-}}
+function exitCode(code) {
+  process.on('exit',function(){process.exit(1)});
+}

tests/.gitattributes

@@ -4,3 +4,4 @@ sample-work.js.bak -text
 tags               -text
 *.stdout           -text
 *.stderr           -text
+*.error            -text

tests/out/rename-capture-existing-occurrences.error

@@ -1 +1,9 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+renamed binding for a would capture
+existing occurrences of x
+{ line: 36, column: 10 }

tests/out/rename-capture-renamed-occurrences.error

@@ -1 +1,9 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+renamed occurrences of x would be captured
+by existing bindings for a
+x { line: 36, column: 10 } by a { line: 35, column: 38 } FunctionExpression Parameter

tests/out/rename-conflicting-binders.error

@@ -1 +1,9 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+renamed binding for a would conflict
+with existing binding for b in the same scope
+{ line: 35, column: 40 } 'FunctionExpression Parameter'

tests/out/rename-function-in-catch-1.error

@@ -1 +1,8 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+cannot rename declaration hoisted over catch
+f { line: 28, column: 13 }

tests/out/rename-function-in-catch-2.error

@@ -1 +1,8 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+cannot rename declaration hoisted over catch
+f { line: 28, column: 13 }

tests/out/rename-function-in-catch-3.error

@@ -1 +1,8 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+cannot rename declaration hoisted over catch
+f { line: 28, column: 13 }

tests/out/rename-global-no-binder.error

@@ -1 +1,7 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+no binding scope found

tests/out/rename-introduce-catch-hoist-conflict.error

@@ -1 +1,9 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+renamed occurrences of ff would be captured
+by existing bindings for f
+ff { line: 42, column: 6 } by f { line: 41, column: 9 } CatchClause Parameter

tests/out/rename-invalid-newName.error

@@ -1 +1 @@
-null
+Error: Command failed: not a valid variable name >new-name<

tests/out/rename-invalid-oldName.error

@@ -1 +1 @@
-null
+Error: Command failed: not a valid variable name >old-name<

tests/out/rename-var-in-catch.error

@@ -1 +1,8 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+cannot rename declaration hoisted over catch
+e { line: 20, column: 8 }

tests/out/rename-wrong-position.error

@@ -1 +1,7 @@
-null
+Error: Command failed: WARNING! hoisting var declaration over catch of same name: e
+{ start: { line: 20, column: 8 },
+  end: { line: 20, column: 16 } }
+WARNING! hoisting function declaration over catch of same name: f
+{ start: { line: 28, column: 4 },
+  end: { line: 28, column: 24 } }
+no binding scope found