-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
page action issues/improvements #42
Comments
This comment has been minimized.
This comment has been minimized.
There are two instances when the page action is meant to be visible:
Both situations share the following conditions. They are meant to happen only when:
Once a request is upgraded to HTTPS, the extension also shows the icon for all subsequent requests to that site over HTTPS (even if it does not need to redirect them because they are already HTTPS requests) that happen in the first 100 to 300 seconds (this varies purposely) after the redirection takes place. As far as I can see, the extension is working as intended regarding this, but this is not the first time someone brought this to my attention (in #13 for example). It's understandable that the behavior looks erratic to someone who does not know exactly what is going on behind the scenes. A toolbar icon would likely prevent such confusion. I may eventually add one, but that is very low priority to be honest. |
Thanks. Still getting my head around things such as these. UX feels just a bit off when (for example):
|
You get that in FF70? Can you give me an example of a site where you get that? Also provide steps to reproduce, please. |
That's actually very easy to reproduce, and is expected behavior, because whitelisting means ignoring. If you whitelist a site that supports only HTTPS (no HTTP), whitelisting is useless (you'll end up connecting over HTTPS anyway, and HTTPZ will have nothing to do with that = no reason to display the icon) |
http://meyerweb.com/eric/thoughts/2017/03/07/welcome-to-the-grid STR
|
Should work as intended now. Thanks for the feedback 👍 |
Without reopening … 0.10.2 plus flip-flopping, I pushed things to a point where, after removal from the whitelist, it was difficult to regain the page action (for re-addition to the list). This successive flip-flopping is probably insanely pushy so I should not expect the behaviour to be easily reproducible. A screen recording: Worth noting but IMHO entirely negligible.
ThoughtsFirefox on FreeBSD is Tier-3. If behaviours are not reproducible on either of the higher tiers then it's possible that I'm exposing a Tier-3 issue … possible but (in my experience) unlikely. Defocusing from this issue … sometimes where there's a sense of randomness with an extension, I look to this:
FWIW I haven't sensed 1378459 in any of my tests in recent days. |
I'm pretty sure that's actually because the browser is fetching the previously rendered page from the fastback cache, which does not trigger network requests (so HTTPZ does not have to do anything). Sorry, I totally forgot about it in this comment. Go to If the page action still seems to be displayed at random, see if there are any errors in the console related to In that case, I don't consider that a problem, because the extension is showing the page action when it redirects requests, and not showing it when it doesn't have to do anything according to the criteria above (which is the point of using a page action instead of a toolbar button). It is not unexpected behavior to me, but it certainly is to some users (such as yourself), so I might do something about it anyway if I come up with something nice code-wise. |
- prevent caching main-doc requests upgraded by HTTPZ, in case the user needs to whitelist them - show the page action after content is loaded from the memory cache or fastback caches
0.11.0b test results – Firefox 70.0.1 (64-bit)Three browser defaults:
– and HTTPZ in its default automatic mode. http://meyerweb.com/eric/thoughts/2017/03/07/welcome-to-the-grid Page action behaviours all good. http://thegearcalculator.appspot.com/ Page action behaviours all good. The page action invites removal from the whitelist when the whitelist is empty. Switch from automatic to manual, forget ignored sites, save, http://vpri.org/ leads to the HTTPZ error page (underlying error: SSL_ERROR_BAD_CERT_DOMAIN) |
That was an oversight. 😅 Should work in |
Fix confirmed, thanks, there's no longer a page action at http://vpri.org. |
Thank you. You have been of great help. I ended up rolling back those changes and replaced them with a different approach that is simpler and more effective, because I noticed another issue with the initial approach. I'll try to make another pre-release when I can. |
Likewise, thank you,
– your responses are superb.
(Was that, the HTTPZ error page sometimes not appearing when expected with manual fallback?) |
No, it had to do with the page action, but I also fixed other minor issues while refactoring the code. |
Spun off from #37 (comment) test 5:
http://thegearcalculator.appspot.com
Pre-release 0.10.0b4 with Firefox,
Sometimes the page action disappears (appears greyed out beneath the ⋯ menu). When this occurs after whitelisting, it's necessary to use the preferences for the extension if the listing is to be removed.
Parts of these two screen recordings might suggest transient improvement after disabling enhanced tracking protection, but there's a sense of randomness; I have not figured out how to make things consistently reproducible.
2019-11-19 07:18.mp4
2019-11-19 07:24.mp4
Refreshing the profile is not a workaround.
Please note, I have not tested release 0.9.4 with the site with Firefox.
(I hope that the Waterfox Classic (Firefox 56.⋯)-oriented enhancements in 0.10.0b4 are not detrimental to Firefox Quantum use cases.)
The text was updated successfully, but these errors were encountered: