-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show list of exceptions added to whitelist #5
Comments
Indeed, user's exceptions aren't listed anywhere in addon options nevertheless if the idea is only to spot them it's always possible to check
It can even be manually edited (once Firefox closed) but that's a bit of a prehistorical way of doing things, I guess! |
Please don't implement this feature without providing support for incognito mode. There should be an option to exclude sites in incognito mode from being added to the exceptions list. |
@in4u I don't see your comment being related to this issue. As you see in the above, exceptions are saved right now in |
Yes, I am aware that the exceptions are stored there. In fact, in the absence of incognito mode, better there instead of main interface! As for the comment relation issue, the only reason I posted here instead of opening a separate feature request for incognito mode is that I don't feel any strong need for it unless your proposed enhancement is implemented. |
Now that FF stores data in sqlite files (and not simple storage.js files), this functionality is probably even more important. |
- Fix onErrorOccurred HTTPS listener check (#10) - Implement whitelist UI in options menu. Items added to the whitelist from an incognito window will not get listed. Closes #5 - Fix minor issues with pageAction. Shouldn't be displayed on server redirection from http to https when the site is whitelisted and such - Implement option to remember secure sites + options page improvements (related to #8)
Please try Note that hostnames added to the whitelist from an incognito window are only invisible if added via the icon's popup. I'm not sure I'm going to leave it that way. |
@claustromaniac Seems OK to me. I suggest highlighting info regarding incognito whitelisting behaviour (probably in the toolbar icon description itself) so that people are aware of it and don't raise issues about sites missing from the whitelisted hostnames list. Another thing I noticed is that the icon for a site sometimes remains disabled and comes back on randomly (either after few tabs are opened/closed, or browser is restarted, or site is reloaded in new window/tab, or cache is refreshed, etc. I can't pinpoint the actual trigger). But this is a pre-existing problem which has nothing to do with your latest update. I don't use the icon so it has never bothered me. |
Thanks for testing, and for the suggestions.
What you describe might not be a problem at all. The extension is only meant to kick in when the browser tries to navigate to an If you want to see the extension in action, edit the URL in this tab and change the scheme to |
The specific problem which I encountered while testing was that occasionally an Anyway, I have two more suggestions:
|
Good idea.
Great idea.
I'm fine with them being included for manual viewing/editing.
Me as well. |
Should be fixed in As for your other suggestions, I tried to add those too to the |
Surprisingly, in this version, whitelisting feature is not working for me at all. Choosing to whitelist from the icon has absolutely no effect regardless of being in normal or incognito mode. It doesn't even show up in the options page or exported file. On manually entering the hostname, it shows up in the exported file and is visible in the options page too but the feature does not work as intended and the site is treated as non-whitelisted. |
Can you give me an example of a site you can't whitelist? I couldn't reproduce that issue on my end. If you don't mind, open a new issue for that (or for further suggestions), to avoid going off-topic and keep some order. |
Any site, e.g. {
"ignorePeriod": 0,
"ignored": {},
"incognitoWhitelist": {},
"knownSecure": {},
"rememberSecureSites": false,
"whitelist": {}
} I think it's better if you create a new issue requesting feedback for the beta version so that others may also test and pitch in. Otherwise I'll open my issue in a day or two after playing around a bit more. |
Unless I'm mistaken, currently user's exceptions aren't listed anywhere in addon options so it's hard track them. I think it would be nice to have list of them with the ability to delete specific sites.
The text was updated successfully, but these errors were encountered: