Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] iPhone 6 don't support bigInt #54

Closed
alanlawlor opened this issue Jul 14, 2021 · 9 comments
Closed

[BUG] iPhone 6 don't support bigInt #54

alanlawlor opened this issue Jul 14, 2021 · 9 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@alanlawlor
Copy link

Describe the bug
Using iPhone 6+ on ios12.5
Tried on Safari and Chrome browsers

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://covid19passbook.netlify.app/
  2. Tap on “Start scanning” button
  3. Nothing happens
  4. Tap on “import picture” button
  5. Nothing happens

In the case of chrome, I checked iOS settings and Chrome has access to Camera and to Photos (read and write)

Expected behavior
After tapping on button, expect to see a camera window open or a gallery of my photos to select.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: iPhone6 plus
  • OS: iOS 12.5.3
  • Browser: both chrome & safari have same problem

Additional context
Add any other context about the problem here.

@alanlawlor alanlawlor added the bug Something isn't working label Jul 14, 2021
@clawfire
Copy link
Owner

Hi there 😃

That sounds strange; accessing the camera require using the site in a plain browser and not an "in-app" browser like the one used in Messenger, Facebook, Twitter, ... That's a limitation both from the app creator (for Facebook, Messenger) and Apple (for Twitter, Instagram, ...). But it seems to be your case, right?

Btw, pushing a passbook in the Apple wallet requires using Safari so far. Didn't find how to make it work for another browser (since we are not generating something on a server, all your data staying in your browser, but it means you're not "downloading" something per se, it's all happening in memory)

We are working on some improvements to detect and tell users what to do when they are in that case #25

@clawfire clawfire added bug:camera Issues with the camera capture question Further information is requested labels Jul 14, 2021
@clawfire clawfire added this to Needs triage in Bug Triage Jul 26, 2021
@github-actions
Copy link

This issue seems to be a little bit old and no ones seems to be able to help 😕. Or waiting for more informations from the reporter ⏳. If no new activity, It will be closed in 25 days

@clawfire
Copy link
Owner

Hey there. I pushed a lot of changes recently, could you try it again ? 😃

@alanlawlor
Copy link
Author

alanlawlor commented Aug 1, 2021 via email

@clawfire
Copy link
Owner

clawfire commented Aug 2, 2021

Seems we have an issue with iPhone 6.

@clawfire
Copy link
Owner

clawfire commented Aug 2, 2021

Found why.
I'm using a javascript feature that is supported by Safari since ios 14.4 but iPhone 6 are blocked to ios 12 max :(

This seems to be require to be able to use the cryptographic functions to decode the content of the qrcode (not the qr code itself but the content isn't readable like this)

https://caniuse.com/bigint

@clawfire clawfire added this to To do in Release 1.7 Aug 2, 2021
@clawfire clawfire removed bug:camera Issues with the camera capture question Further information is requested labels Aug 2, 2021
@clawfire clawfire changed the title [BUG] tapping buttons on landing web page not responding on iPhone 6 [BUG] iPhone 6 don't support bigInt Aug 2, 2021
@clawfire clawfire moved this from Needs triage to High priority in Bug Triage Aug 2, 2021
@clawfire
Copy link
Owner

clawfire commented Aug 2, 2021

TODO :

  • Add the feature detection of bigInt (or ios 14 as requirement) with a screen saying it's impossible to use

@clawfire
Copy link
Owner

clawfire commented Aug 6, 2021

Found out the bug was caused by the lack of support of BigInt in Safari before version 14. And there's no polyfill we can put in place to support this. BigInt represents big integer numbers in memory, required for cryptographic manipulation such as decoding the QR code.

I implemented a detection feature of lack of this functionality and warned the user with a message + prevent to discard the message (since the app will be totally unusable anyway).

iPhones 6 and 6+ are all stuck in iOS12 max, which isn't supported.
IPhones after 6 (including 6s) can upgrade to iOS14 and should ti get the app working.

@clawfire clawfire closed this as completed Aug 6, 2021
Bug Triage automation moved this from High priority to Closed Aug 6, 2021
Release 1.7 automation moved this from To do to Done Aug 6, 2021
@clawfire clawfire added the wontfix This will not be worked on label Aug 6, 2021
@clawfire
Copy link
Owner

clawfire commented Aug 6, 2021

But you can us the app on your desktop if you want 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
Development

No branches or pull requests

2 participants